Skip to content

Commit e8a9bc0

Browse files
committed
run stable fmt through rustup
1 parent 5170569 commit e8a9bc0

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

crates/rust-analyzer/tests/slow-tests/tidy.rs

+3-4
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,18 @@ use xshell::cmd;
1313
fn check_code_formatting() {
1414
let sh = &Shell::new().unwrap();
1515
sh.change_dir(sourcegen::project_root());
16-
sh.set_var("RUSTUP_TOOLCHAIN", "stable");
1716

18-
let out = cmd!(sh, "rustfmt --version").read().unwrap();
17+
let out = cmd!(sh, "rustup run stable rustfmt --version").read().unwrap();
1918
if !out.contains("stable") {
2019
panic!(
2120
"Failed to run rustfmt from toolchain 'stable'. \
2221
Please run `rustup component add rustfmt --toolchain stable` to install it.",
2322
)
2423
}
2524

26-
let res = cmd!(sh, "cargo fmt -- --check").run();
25+
let res = cmd!(sh, "rustup run stable cargo fmt -- --check").run();
2726
if res.is_err() {
28-
let _ = cmd!(sh, "cargo fmt").run();
27+
let _ = cmd!(sh, "rustup run stable cargo fmt").run();
2928
}
3029
res.unwrap()
3130
}

crates/sourcegen/src/lib.rs

+8-6
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ impl fmt::Display for Location {
136136
}
137137

138138
fn ensure_rustfmt(sh: &Shell) {
139-
let version = cmd!(sh, "rustfmt --version").read().unwrap_or_default();
139+
let version = cmd!(sh, "rustup run stable rustfmt --version").read().unwrap_or_default();
140140
if !version.contains("stable") {
141141
panic!(
142142
"Failed to run rustfmt from toolchain 'stable'. \
@@ -147,13 +147,15 @@ fn ensure_rustfmt(sh: &Shell) {
147147

148148
pub fn reformat(text: String) -> String {
149149
let sh = Shell::new().unwrap();
150-
sh.set_var("RUSTUP_TOOLCHAIN", "stable");
151150
ensure_rustfmt(&sh);
152151
let rustfmt_toml = project_root().join("rustfmt.toml");
153-
let mut stdout = cmd!(sh, "rustfmt --config-path {rustfmt_toml} --config fn_single_line=true")
154-
.stdin(text)
155-
.read()
156-
.unwrap();
152+
let mut stdout = cmd!(
153+
sh,
154+
"rustup run stable rustfmt --config-path {rustfmt_toml} --config fn_single_line=true"
155+
)
156+
.stdin(text)
157+
.read()
158+
.unwrap();
157159
if !stdout.ends_with('\n') {
158160
stdout.push('\n');
159161
}

0 commit comments

Comments
 (0)