avoid creating vec in methods in ModuleItems

kckeiks · kckeiks · commit e2512f70ce1a · 2022-04-09T13:49:36.000-04:00
diff --git a/compiler/rustc_middle/src/hir/map/mod.rs b/compiler/rustc_middle/src/hir/map/mod.rs
@@ -159,11 +159,11 @@ impl<'hir> Map<'hir> {
     }
 
     pub fn items(self) -> impl Iterator<Item = ItemId> + 'hir {
-        self.tcx.hir_crate_items(()).items.iter().map(|id| *id)
+        self.tcx.hir_crate_items(()).items.iter().copied()
     }
 
     pub fn par_items(self, f: impl Fn(ItemId) + Sync + Send) {
-        par_for_each_in(self.tcx.hir_crate_items(()).items.to_vec(), f);
+        par_for_each_in(&self.tcx.hir_crate_items(()).items[..], |id| f(*id));
     }
 
     pub fn def_key(self, def_id: LocalDefId) -> DefKey {

Original file line number	Diff line number	Diff line change
`@@ -159,11 +159,11 @@ impl<'hir> Map<'hir> {`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`pub fn items(self) -> impl Iterator<Item = ItemId> + 'hir {`
`162`		`- self.tcx.hir_crate_items(()).items.iter().map(\|id\| *id)`
	`162`	`+ self.tcx.hir_crate_items(()).items.iter().copied()`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`pub fn par_items(self, f: impl Fn(ItemId) + Sync + Send) {`
`166`		`- par_for_each_in(self.tcx.hir_crate_items(()).items.to_vec(), f);`
	`166`	`+ par_for_each_in(&self.tcx.hir_crate_items(()).items[..], \|id\| f(*id));`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`pub fn def_key(self, def_id: LocalDefId) -> DefKey {`