Skip to content

Commit e03c809

Browse files
committed
Remove some unnecessary FIXME comments.
The comments didn't make much sense to me. I asked Matthew Jasper on Zulip about it and they said: > I think that at the time I wanted to replace all (or most of) this > with a reference to the HIR Id of the variable. I'll give this a look > to see if it's still a reasonable idea, but removing the comments is > fine. and then: > I don't think that changing this to an HirId would be better, > recovering the information from the HIR seems like too much effort in > exchange for making the MIR a little smaller.
1 parent c49e2df commit e03c809

File tree

1 file changed

+0
-3
lines changed
  • compiler/rustc_middle/src/mir

1 file changed

+0
-3
lines changed

compiler/rustc_middle/src/mir/mod.rs

-3
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,6 @@ pub struct LocalDecl<'tcx> {
961961
/// Temporaries and the return place are always mutable.
962962
pub mutability: Mutability,
963963

964-
// FIXME(matthewjasper) Don't store in this in `Body`
965964
pub local_info: ClearCrossCrate<Box<LocalInfo<'tcx>>>,
966965

967966
/// The type of this local.
@@ -971,7 +970,6 @@ pub struct LocalDecl<'tcx> {
971970
/// e.g., via `let x: T`, then we carry that type here. The MIR
972971
/// borrow checker needs this information since it can affect
973972
/// region inference.
974-
// FIXME(matthewjasper) Don't store in this in `Body`
975973
pub user_ty: Option<Box<UserTypeProjections>>,
976974

977975
/// The *syntactic* (i.e., not visibility) source scope the local is defined
@@ -1079,7 +1077,6 @@ pub enum LocalInfo<'tcx> {
10791077
AggregateTemp,
10801078
/// A temporary created for evaluation of some subexpression of some block's tail expression
10811079
/// (with no intervening statement context).
1082-
// FIXME(matthewjasper) Don't store in this in `Body`
10831080
BlockTailTemp(BlockTailInfo),
10841081
/// A temporary created during evaluating `if` predicate, possibly for pattern matching for `let`s,
10851082
/// and subject to Edition 2024 temporary lifetime rules

0 commit comments

Comments
 (0)