Skip to content

Commit e0281d9

Browse files
committed
core: Stamp out XXXes (comments only)
1 parent 2de8e8f commit e0281d9

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/libcore/os.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ pub mod win32 {
145145
/*
146146
Accessing environment variables is not generally threadsafe.
147147
This uses a per-runtime lock to serialize access.
148-
XXX: It would probably be appropriate to make this a real global
148+
FIXME #4726: It would probably be appropriate to make this a real global
149149
*/
150150
fn with_env_lock<T>(f: &fn() -> T) -> T {
151151
use private::global::global_data_clone_create;

src/libcore/private/finally.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ pub trait Finally<T> {
3131
}
3232

3333
impl<T> &fn() -> T: Finally<T> {
34-
// XXX: Should not require a mode here
34+
// FIXME #4518: Should not require a mode here
3535
fn finally(&self, +dtor: &fn()) -> T {
3636
let _d = Finallyalizer {
3737
dtor: dtor
@@ -88,7 +88,7 @@ fn test_retval() {
8888

8989
#[test]
9090
fn test_compact() {
91-
// XXX Should be able to use a fn item instead
91+
// FIXME #4727: Should be able to use a fn item instead
9292
// of a closure for do_some_fallible_work,
9393
// but it's a type error.
9494
let do_some_fallible_work: &fn() = || { };

src/libcore/private/global.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ fn get_global_state() -> Exclusive<GlobalState> {
160160

161161
const POISON: int = -1;
162162

163-
// XXX: Doing atomic_cxchg to initialize the global state
163+
// FIXME #4728: Doing atomic_cxchg to initialize the global state
164164
// lazily, which wouldn't be necessary with a runtime written
165165
// in Rust
166166
let global_ptr = unsafe { rust_get_global_data_ptr() };

src/libcore/private/weak_task.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ use ops::Drop;
3030

3131
type ShutdownMsg = ();
3232

33-
// XXX: This could be a PortOne but I've experienced bugginess
33+
// FIXME #4729: This could be a PortOne but I've experienced bugginess
3434
// with oneshot pipes and try_send
3535
pub unsafe fn weaken_task(f: &fn(Port<ShutdownMsg>)) {
3636
let service = global_data_clone_create(global_data_key,

0 commit comments

Comments
 (0)