Skip to content

Commit ce32691

Browse files
committed
bootstrap: Backup settings.json to the correct filename
The old code actually replaced `.json` with `.bak` (so, `settings.bak`), rather than appending `.bak` as claimed (`settings.json.bak`). `Path::set_extension` can instead be used with dots: > The new extension may contain dots and will be used in its entirety, > but only the part after the final dot will be reflected in > self.extension.
1 parent 69a6373 commit ce32691

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/bootstrap/setup.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ fn create_vscode_settings_maybe(config: &Config) -> io::Result<()> {
582582
Some(false) => {
583583
// exists and is not current version or outdated, so back it up
584584
let mut backup = vscode_settings.clone();
585-
backup.set_extension("bak");
585+
backup.set_extension("json.bak");
586586
eprintln!("warning: copying `settings.json` to `settings.json.bak`");
587587
fs::copy(&vscode_settings, &backup)?;
588588
"Updated"

0 commit comments

Comments
 (0)