Skip to content

Commit c96ae78

Browse files
committed
Comments only: annotate FIXMEs in core::os
1 parent 39d9c30 commit c96ae78

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

src/libcore/os.rs

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export last_os_error;
3636
export set_exit_status;
3737
export walk_dir;
3838

39-
// FIXME: move these to str perhaps?
39+
// FIXME: move these to str perhaps? #2620
4040
export as_c_charp, fill_charp_buf;
4141

4242
native mod rustrt {
@@ -86,7 +86,7 @@ mod win32 {
8686
fn fill_utf16_buf_and_decode(f: fn(*mut u16, dword) -> dword)
8787
-> option<str> {
8888

89-
// FIXME: remove these when export globs work properly.
89+
// FIXME: remove these when export globs work properly. #1238
9090
import libc::funcs::extra::kernel32::*;
9191
import libc::consts::os::extra::*;
9292

@@ -167,7 +167,7 @@ mod global_env {
167167
sched: some({
168168
mode: task::single_threaded,
169169
// FIXME: This would be a good place to use
170-
// a very small native stack
170+
// a very small native stack (#2621)
171171
native_stack_size: none
172172
})
173173
with task::get_opts(builder)
@@ -227,7 +227,7 @@ mod global_env {
227227
#[cfg(unix)]
228228
fn setenv(n: str, v: str) {
229229

230-
// FIXME: remove this when export globs work properly.
230+
// FIXME: remove this when export globs work properly. #1238
231231
import libc::funcs::posix01::unistd::setenv;
232232
str::as_c_str(n) {|nbuf|
233233
str::as_c_str(v) {|vbuf|
@@ -239,7 +239,7 @@ mod global_env {
239239

240240
#[cfg(windows)]
241241
fn setenv(n: str, v: str) {
242-
// FIXME: remove imports when export globs work properly.
242+
// FIXME: remove imports when export globs work properly. #1238
243243
import libc::funcs::extra::kernel32::*;
244244
import win32::*;
245245
as_utf16_p(n) {|nbuf|
@@ -329,7 +329,7 @@ fn pipe() -> {in: c_int, out: c_int} {
329329

330330
#[cfg(windows)]
331331
fn pipe() -> {in: c_int, out: c_int} {
332-
// FIXME: remove this when export globs work properly.
332+
// FIXME: remove this when export globs work properly. #1238
333333
import libc::consts::os::extra::*;
334334
// Windows pipes work subtly differently than unix pipes, and their
335335
// inheritance has to be handled in a different way that I do not fully
@@ -387,7 +387,7 @@ fn self_exe_path() -> option<path> {
387387

388388
#[cfg(target_os = "macos")]
389389
fn load_self() -> option<path> unsafe {
390-
// FIXME: remove imports when export globs work properly.
390+
// FIXME: remove imports when export globs work properly. #1238
391391
import libc::funcs::extra::*;
392392
fill_charp_buf() {|buf, sz|
393393
_NSGetExecutablePath(buf, ptr::mut_addr_of(sz as u32))
@@ -397,7 +397,7 @@ fn self_exe_path() -> option<path> {
397397

398398
#[cfg(windows)]
399399
fn load_self() -> option<path> unsafe {
400-
// FIXME: remove imports when export globs work properly.
400+
// FIXME: remove imports when export globs work properly. #1238
401401
import libc::types::os::arch::extra::*;
402402
import libc::funcs::extra::kernel32::*;
403403
import win32::*;
@@ -500,7 +500,7 @@ fn path_exists(p: path) -> bool {
500500
}
501501

502502
// FIXME: under Windows, we should prepend the current drive letter to paths
503-
// that start with a slash.
503+
// that start with a slash. #2622
504504
#[doc = "
505505
Convert a relative path to an absolute path
506506
@@ -526,11 +526,11 @@ fn make_dir(p: path, mode: c_int) -> bool {
526526

527527
#[cfg(windows)]
528528
fn mkdir(p: path, _mode: c_int) -> bool unsafe {
529-
// FIXME: remove imports when export globs work properly.
529+
// FIXME: remove imports when export globs work properly. #1238
530530
import libc::types::os::arch::extra::*;
531531
import libc::funcs::extra::kernel32::*;
532532
import win32::*;
533-
// FIXME: turn mode into something useful?
533+
// FIXME: turn mode into something useful? #2623
534534
as_utf16_p(p) {|buf|
535535
CreateDirectoryW(buf, unsafe::reinterpret_cast(0))
536536
!= (0 as BOOL)
@@ -588,7 +588,7 @@ fn remove_dir(p: path) -> bool {
588588

589589
#[cfg(windows)]
590590
fn rmdir(p: path) -> bool {
591-
// FIXME: remove imports when export globs work properly.
591+
// FIXME: remove imports when export globs work properly. #1238
592592
import libc::funcs::extra::kernel32::*;
593593
import libc::types::os::arch::extra::*;
594594
import win32::*;
@@ -610,7 +610,7 @@ fn change_dir(p: path) -> bool {
610610

611611
#[cfg(windows)]
612612
fn chdir(p: path) -> bool {
613-
// FIXME: remove imports when export globs work properly.
613+
// FIXME: remove imports when export globs work properly. #1238
614614
import libc::funcs::extra::kernel32::*;
615615
import libc::types::os::arch::extra::*;
616616
import win32::*;
@@ -633,7 +633,7 @@ fn copy_file(from: path, to: path) -> bool {
633633

634634
#[cfg(windows)]
635635
fn do_copy_file(from: path, to: path) -> bool {
636-
// FIXME: remove imports when export globs work properly.
636+
// FIXME: remove imports when export globs work properly. #1238
637637
import libc::funcs::extra::kernel32::*;
638638
import libc::types::os::arch::extra::*;
639639
import win32::*;

0 commit comments

Comments
 (0)