Skip to content

Commit c904b1b

Browse files
committed
rustdoc: Fix some minor issues per reviewer
1 parent 7cd0280 commit c904b1b

File tree

4 files changed

+22
-25
lines changed

4 files changed

+22
-25
lines changed

src/librustdoc/html/static/main.js

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1661,18 +1661,18 @@
16611661
}
16621662
if (hasClass(relatedDoc, "docblock")) {
16631663
var action = mode;
1664-
if (action == "toggle") {
1665-
if(hasClass(relatedDoc, "hidden-by-usual-hider")) {
1666-
action="show";
1664+
if (action === "toggle") {
1665+
if (hasClass(relatedDoc, "hidden-by-usual-hider")) {
1666+
action = "show";
16671667
} else {
1668-
action="hide";
1668+
action = "hide";
16691669
}
16701670
}
1671-
if (action == "hide") {
1671+
if (action === "hide") {
16721672
addClass(relatedDoc, "hidden-by-usual-hider");
16731673
onEach(toggle.childNodes, adjustToggle(true));
16741674
addClass(toggle.parentNode, 'collapsed');
1675-
} else if (action == "show") {
1675+
} else if (action === "show") {
16761676
removeClass(relatedDoc, "hidden-by-usual-hider");
16771677
removeClass(toggle.parentNode, 'collapsed');
16781678
onEach(toggle.childNodes, adjustToggle(false));
@@ -1682,14 +1682,14 @@
16821682
// we are collapsing the impl block
16831683
function implHider(addOrRemove) {
16841684
return function(n) {
1685-
if(hasClass(n, "method")) {
1685+
if (hasClass(n, "method")) {
16861686
if (addOrRemove) {
16871687
addClass(n, "hidden-by-impl-hider");
16881688
} else {
16891689
removeClass(n, "hidden-by-impl-hider");
16901690
}
16911691
var ns = n.nextElementSibling;
1692-
while(true) {
1692+
while (true) {
16931693
if (ns && (
16941694
hasClass(ns, "docblock") ||
16951695
hasClass(ns, "stability") ||
@@ -1715,24 +1715,26 @@
17151715
relatedDoc = relatedDoc.nextElementSibling;
17161716
}
17171717

1718-
if (!relatedDoc) return;
1718+
if (!relatedDoc) {
1719+
return;
1720+
}
17191721

17201722
// Hide all functions, but not associated types/consts
17211723

17221724
var action = mode;
1723-
if (action == "toggle") {
1724-
if(hasClass(relatedDoc, "fns-now-collapsed")) {
1725-
action="show";
1725+
if (action === "toggle") {
1726+
if (hasClass(relatedDoc, "fns-now-collapsed")) {
1727+
action = "show";
17261728
} else {
1727-
action="hide";
1729+
action = "hide";
17281730
}
17291731
}
17301732

1731-
if(action == "show") {
1733+
if (action === "show") {
17321734
removeClass(relatedDoc, "fns-now-collapsed");
17331735
onEach(toggle.childNodes, adjustToggle(false));
17341736
onEach(relatedDoc.childNodes, implHider(false));
1735-
} else if (action == "hide") {
1737+
} else if (action === "hide") {
17361738
addClass(relatedDoc, "fns-now-collapsed");
17371739
onEach(toggle.childNodes, adjustToggle(true));
17381740
onEach(relatedDoc.childNodes, implHider(true));

src/librustdoc/html/static/rustdoc.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,3 +1189,8 @@ kbd {
11891189
z-index: 1;
11901190
}
11911191
}
1192+
1193+
.hidden-by-impl-hider,
1194+
.hidden-by-usual-hider {
1195+
display: none;
1196+
}

src/librustdoc/html/static/themes/dark.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,3 @@ kbd {
386386
background: #353535;
387387
}
388388
}
389-
390-
.hidden-by-impl-hider,
391-
.hidden-by-usual-hider {
392-
display: none;
393-
}

src/librustdoc/html/static/themes/main.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -383,8 +383,3 @@ kbd {
383383
background: #fff;
384384
}
385385
}
386-
387-
.hidden-by-impl-hider,
388-
.hidden-by-usual-hider {
389-
display: none;
390-
}

0 commit comments

Comments
 (0)