Skip to content

Commit be8b091

Browse files
committed
Try removing code marked with "I don't think this is necessary"
1 parent 290206b commit be8b091

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

src/rt/arch/i386/morestack.S

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,6 @@ MORESTACK:
213213

214214
popl %ebp
215215

216-
// FIXME: I don't think these rules are necessary
217-
// since the unwinder should never encounter an instruction
218-
// pointer pointing here.
219-
#if defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__)
220-
// Restore the rule for how to find %ebp
221-
.cfi_restore %ebp
222-
// Tell the unwinder how to find the CFA in terms of %esp
223-
.cfi_def_cfa %esp, 16
224-
#endif
225216
retl $8
226217

227218
.L$bail:

src/rt/arch/x86_64/morestack.S

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ MORESTACK:
5151

5252
subq $184, %rsp
5353

54-
// FIXME: libgcc also saves rax. not sure if we need to
54+
// FIXME: libgcc also saves rax. not sure if we need to (#2685)
5555

5656
// Save argument registers of the original function
5757
movq %rdi, (%rsp)
@@ -133,11 +133,6 @@ MORESTACK:
133133

134134
popq %rax // Restore the return value
135135
popq %rbp
136-
// FIXME: I don't think these rules are necessary
137-
// since the unwinder should never encounter an instruction
138-
// pointer pointing here.
139-
.cfi_restore %rbp
140-
.cfi_def_cfa %rsp, 16
141136
ret
142137

143138
.cfi_endproc

0 commit comments

Comments
 (0)