Skip to content

Commit b3d4379

Browse files
committed
Fallout from new termination semantics
1 parent 6987ad2 commit b3d4379

File tree

5 files changed

+15
-19
lines changed

5 files changed

+15
-19
lines changed

src/librustrt/local.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,15 @@ impl Local<local_ptr::Borrowed<Task>> for Task {
5252

5353
#[cfg(test)]
5454
mod test {
55-
extern crate rustrt;
56-
5755
use std::prelude::*;
58-
use rustrt::thread::Thread;
56+
use thread::Thread;
5957
use super::*;
6058
use task::Task;
6159

6260
#[test]
6361
fn thread_local_task_smoke_test() {
6462
Thread::start(proc() {
65-
let task = box Task::new();
63+
let task = box Task::new(None, None);
6664
Local::put(task);
6765
let task: Box<Task> = Local::take();
6866
cleanup_task(task);
@@ -72,11 +70,11 @@ mod test {
7270
#[test]
7371
fn thread_local_task_two_instances() {
7472
Thread::start(proc() {
75-
let task = box Task::new();
73+
let task = box Task::new(None, None);
7674
Local::put(task);
7775
let task: Box<Task> = Local::take();
7876
cleanup_task(task);
79-
let task = box Task::new();
77+
let task = box Task::new(None, None);
8078
Local::put(task);
8179
let task: Box<Task> = Local::take();
8280
cleanup_task(task);
@@ -86,7 +84,7 @@ mod test {
8684
#[test]
8785
fn borrow_smoke_test() {
8886
Thread::start(proc() {
89-
let task = box Task::new();
87+
let task = box Task::new(None, None);
9088
Local::put(task);
9189

9290
unsafe {
@@ -100,7 +98,7 @@ mod test {
10098
#[test]
10199
fn borrow_with_return() {
102100
Thread::start(proc() {
103-
let task = box Task::new();
101+
let task = box Task::new(None, None);
104102
Local::put(task);
105103

106104
{
@@ -115,7 +113,7 @@ mod test {
115113
#[test]
116114
fn try_take() {
117115
Thread::start(proc() {
118-
let task = box Task::new();
116+
let task = box Task::new(None, None);
119117
Local::put(task);
120118

121119
let t: Box<Task> = Local::try_take().unwrap();

src/librustrt/mutex.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -649,13 +649,11 @@ mod imp {
649649

650650
#[cfg(test)]
651651
mod test {
652-
extern crate rustrt;
653-
654652
use std::prelude::*;
655653

656654
use std::mem::drop;
657655
use super::{StaticNativeMutex, NATIVE_MUTEX_INIT};
658-
use rustrt::thread::Thread;
656+
use thread::Thread;
659657

660658
#[test]
661659
fn smoke_lock() {

src/librustrt/task.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -544,11 +544,10 @@ impl Death {
544544

545545
#[cfg(test)]
546546
mod test {
547-
extern crate rustrt;
548-
549547
use super::*;
550548
use std::prelude::*;
551549
use std::task;
550+
use unwind;
552551

553552
#[test]
554553
fn tls() {
@@ -594,20 +593,20 @@ mod test {
594593
#[test]
595594
#[should_fail]
596595
fn test_begin_unwind() {
597-
use rustrt::unwind::begin_unwind;
596+
use unwind::begin_unwind;
598597
begin_unwind("cause", &(file!(), line!()))
599598
}
600599

601600
#[test]
602601
fn drop_new_task_ok() {
603-
drop(Task::new());
602+
drop(Task::new(None, None));
604603
}
605604

606605
// Task blocking tests
607606

608607
#[test]
609608
fn block_and_wake() {
610-
let task = box Task::new();
609+
let task = box Task::new(None, None);
611610
let task = BlockedTask::block(task).wake().unwrap();
612611
task.drop();
613612
}

src/test/run-pass/out-of-stack-new-thread-no-split.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,12 @@ fn main() {
3636
let args = os::args();
3737
let args = args.as_slice();
3838
if args.len() > 1 && args[1].as_slice() == "recurse" {
39+
let (tx, rx) = channel();
3940
spawn(proc() {
4041
recurse();
42+
tx.send(());
4143
});
44+
rx.recv();
4245
} else {
4346
let recurse = Command::new(args[0].as_slice()).arg("recurse").output().unwrap();
4447
assert!(!recurse.status.success());

src/test/run-pass/process-spawn-with-unicode-params.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
// non-ASCII characters. The child process ensures all the strings are
1717
// intact.
1818

19-
extern crate native;
20-
2119
use std::io;
2220
use std::io::fs;
2321
use std::io::Command;

0 commit comments

Comments
 (0)