Skip to content

Commit ad52fcd

Browse files
committed
Do not hide runtime tab when there are no results
1 parent 2822e8a commit ad52fcd

File tree

2 files changed

+10
-19
lines changed

2 files changed

+10
-19
lines changed

site/frontend/src/pages/compare/page.vue

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,15 @@ async function loadCompareData(
8181
)
8282
)
8383
);
84-
if (response.runtime_comparisons.length > 0) {
85-
runtimeSummary.value = computeSummary(
86-
filterNonRelevant(
84+
runtimeSummary.value = computeSummary(
85+
filterNonRelevant(
86+
defaultRuntimeFilter,
87+
computeRuntimeComparisonsWithNonRelevant(
8788
defaultRuntimeFilter,
88-
computeRuntimeComparisonsWithNonRelevant(
89-
defaultRuntimeFilter,
90-
response.runtime_comparisons
91-
)
89+
response.runtime_comparisons
9290
)
93-
);
94-
}
91+
)
92+
);
9593
}
9694
9795
function updateSelection(params: SelectionParams) {
@@ -120,16 +118,12 @@ const selector = loadSelectorFromUrl(urlParams);
120118
const initialTab: Tab = loadTabFromUrl(urlParams) ?? Tab.CompileTime;
121119
const tab: Ref<Tab> = ref(initialTab);
122120
const activeTab = computed((): Tab => {
123-
if (tab.value === Tab.Runtime && !runtimeDataAvailable.value) {
124-
return Tab.CompileTime;
125-
}
126121
if (tab.value === Tab.ArtifactSize && !artifactSizeAvailable.value) {
127122
return Tab.CompileTime;
128123
}
129124
return tab.value;
130125
});
131126
132-
const runtimeDataAvailable = computed(() => runtimeSummary.value !== null);
133127
const artifactSizeAvailable = computed(
134128
() =>
135129
data.value != null &&
@@ -174,7 +168,7 @@ loadCompareData(selector, loading);
174168
:benchmark-info="info"
175169
/>
176170
</template>
177-
<template v-if="runtimeDataAvailable && activeTab === Tab.Runtime">
171+
<template v-if="activeTab === Tab.Runtime">
178172
<RuntimeBenchmarksPage
179173
:data="data"
180174
:selector="selector"

site/frontend/src/pages/compare/tabs.vue

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const props = withDefaults(
1515
defineProps<{
1616
data: CompareResponse;
1717
compileTimeSummary: SummaryGroup;
18-
runtimeSummary: SummaryGroup | null;
18+
runtimeSummary: SummaryGroup;
1919
initialTab?: Tab;
2020
}>(),
2121
{
@@ -65,7 +65,7 @@ function SummaryTable({summary}: {summary: SummaryGroup}) {
6565
</table>
6666
);
6767
}
68-
return <div>No relevant results</div>;
68+
return <div>No results</div>;
6969
}
7070
7171
function formatArtifactSize(size: number): string {
@@ -79,8 +79,6 @@ const bootstrapA = props.data.a.bootstrap_total;
7979
const bootstrapB = props.data.b.bootstrap_total;
8080
const bootstrapValid = bootstrapA > 0.0 && bootstrapB > 0.0;
8181
82-
const runtimeAvailable = computed(() => props.runtimeSummary !== null);
83-
8482
const totalSizeA = Object.values(props.data.a.component_sizes).reduce(
8583
(a, b) => a + b,
8684
0
@@ -109,7 +107,6 @@ const activeTab: Ref<Tab> = ref(props.initialTab);
109107
</div>
110108
</div>
111109
<div
112-
v-if="runtimeAvailable"
113110
class="tab"
114111
title="Runtime benchmarks: measure how long does it take to execute (i.e. how fast are) programs compiled by the compared rustc."
115112
:class="{selected: activeTab === Tab.Runtime}"

0 commit comments

Comments
 (0)