Skip to content

Commit ac41b94

Browse files
authored
Rollup merge of #139488 - GuillaumeGomez:add-missing-gui-test, r=camelid
Add missing regression GUI test Add missing GUI test for #139282 (and also fixes the invalid CSS). cc `@lolbinarycat` r? `@notriddle`
2 parents d5f930f + 30f56df commit ac41b94

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

Diff for: src/librustdoc/html/static/css/rustdoc.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1447,7 +1447,7 @@ so that we can apply CSS-filters to change the arrow color in themes */
14471447
cursor: pointer;
14481448
}
14491449
.setting-check input {
1450-
flex-shrink: 0,
1450+
flex-shrink: 0;
14511451
}
14521452

14531453
.setting-radio input:checked {

Diff for: tests/rustdoc-gui/settings.goml

+14
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,13 @@ compare-elements-position: (".sub form", "#settings", ["x"])
314314
// Check that setting-line has the same margin in this mode as in the popover.
315315
assert-css: (".setting-line", {"margin": |setting_line_margin|})
316316

317+
// We will check that the checkboxes size doesn't change either.
318+
assert-size: (
319+
"#settings label > input[type='checkbox']",
320+
{"width": 19, "height": 19},
321+
ALL,
322+
)
323+
317324
// We now check the display with JS disabled.
318325
assert-false: "noscript section"
319326
javascript: false
@@ -327,3 +334,10 @@ reload:
327334
set-window-size: (300, 1000)
328335
wait-for: "#settings"
329336
assert-css: (".setting-radio", {"cursor": "pointer"})
337+
338+
// We ensure that the checkboxes size didn't change.
339+
assert-size: (
340+
"#settings label > input[type='checkbox']",
341+
{"width": 19, "height": 19},
342+
ALL,
343+
)

0 commit comments

Comments
 (0)