Skip to content

Commit abe2ad0

Browse files
committed
librustc: De-@mut Module::anonymous_children
1 parent 9988970 commit abe2ad0

File tree

1 file changed

+18
-8
lines changed

1 file changed

+18
-8
lines changed

src/librustc/middle/resolve.rs

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ struct Module {
439439
//
440440
// There will be an anonymous module created around `g` with the ID of the
441441
// entry block for `f`.
442-
anonymous_children: @mut HashMap<NodeId,@Module>,
442+
anonymous_children: RefCell<HashMap<NodeId,@Module>>,
443443

444444
// The status of resolving each import in this module.
445445
import_resolutions: @mut HashMap<Name, @mut ImportResolution>,
@@ -471,7 +471,7 @@ impl Module {
471471
children: @mut HashMap::new(),
472472
imports: @mut ~[],
473473
external_module_children: RefCell::new(HashMap::new()),
474-
anonymous_children: @mut HashMap::new(),
474+
anonymous_children: RefCell::new(HashMap::new()),
475475
import_resolutions: @mut HashMap::new(),
476476
glob_count: Cell::new(0),
477477
resolved_import_count: Cell::new(0),
@@ -1579,8 +1579,12 @@ impl Resolver {
15791579
AnonymousModuleKind,
15801580
false,
15811581
false);
1582-
parent_module.anonymous_children.insert(block_id, new_module);
1583-
ModuleReducedGraphParent(new_module)
1582+
{
1583+
let mut anonymous_children = parent_module.anonymous_children
1584+
.borrow_mut();
1585+
anonymous_children.get().insert(block_id, new_module);
1586+
ModuleReducedGraphParent(new_module)
1587+
}
15841588
} else {
15851589
parent
15861590
}
@@ -2031,7 +2035,8 @@ impl Resolver {
20312035
}
20322036
}
20332037

2034-
for (_, &child_module) in module_.anonymous_children.iter() {
2038+
let anonymous_children = module_.anonymous_children.borrow();
2039+
for (_, &child_module) in anonymous_children.get().iter() {
20352040
self.resolve_imports_for_module_subtree(child_module);
20362041
}
20372042
}
@@ -3201,7 +3206,8 @@ impl Resolver {
32013206
}
32023207
}
32033208

3204-
for (_, &module_) in module_.anonymous_children.iter() {
3209+
let anonymous_children = module_.anonymous_children.borrow();
3210+
for (_, &module_) in anonymous_children.get().iter() {
32053211
self.report_unresolved_imports(module_);
32063212
}
32073213
}
@@ -3261,7 +3267,8 @@ impl Resolver {
32613267
}
32623268
}
32633269

3264-
for (_, &child_module) in module_.anonymous_children.iter() {
3270+
let anonymous_children = module_.anonymous_children.borrow();
3271+
for (_, &child_module) in anonymous_children.get().iter() {
32653272
self.record_exports_for_module_subtree(child_module);
32663273
}
32673274
}
@@ -4142,7 +4149,10 @@ impl Resolver {
41424149

41434150
// Move down in the graph, if there's an anonymous module rooted here.
41444151
let orig_module = self.current_module;
4145-
match self.current_module.anonymous_children.find(&block.id) {
4152+
let anonymous_children = self.current_module
4153+
.anonymous_children
4154+
.borrow();
4155+
match anonymous_children.get().find(&block.id) {
41464156
None => { /* Nothing to do. */ }
41474157
Some(&anonymous_module) => {
41484158
debug!("(resolving block) found anonymous module, moving \

0 commit comments

Comments
 (0)