Skip to content

Commit aafcbf1

Browse files
committed
Update comment to make it a FIXME
1 parent a6aa3cb commit aafcbf1

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/librustdoc/json/mod.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,10 @@ impl<'tcx> FormatRenderer<'tcx> for JsonRenderer<'tcx> {
171171
/// the hashmap because certain items (traits and types) need to have their mappings for trait
172172
/// implementations filled out before they're inserted.
173173
fn item(&mut self, item: clean::Item) -> Result<(), Error> {
174-
// We skip children of local blanket implementations, as we'll have already seen the actual
175-
// generic impl, and the generated ones don't need documenting.
174+
// FIXME(CraftSpider): We skip children of local blanket implementations, as we'll have
175+
// already seen the actual generic impl, and the generated ones don't need documenting.
176+
// This is necessary due to the visibility, return type, and self arg of the generated
177+
// impls not quite matching, and will no longer be necessary when the mismatch is fixed.
176178
let local_blanket_impl = match item.def_id {
177179
clean::ItemId::Blanket { impl_id, .. } => impl_id.is_local(),
178180
clean::ItemId::Auto { .. }

0 commit comments

Comments
 (0)