Remove incorrect uses of NVALGRIND, Close #1435.

Author: graydon

mk/platform.mk

@@ -17,10 +17,6 @@ CFG_GCCISH_LINK_FLAGS :=
 # embedded into the executable, so use a no-op command.
 CFG_DSYMUTIL := true
 
-ifeq ($(CFG_VALGRIND),)
-  CFG_GCCISH_CFLAGS += -DNVALGRIND
-endif
-
 ifneq ($(findstring freebsd,$(CFG_OSTYPE)),)
   CFG_LIB_NAME=lib$(1).so
   CFG_LIB_GLOB=lib$(1)-*.so

src/rt/rust_stack.cpp

@@ -18,15 +18,13 @@ register_valgrind_stack(stk_seg *stk) {
 
 void
 reuse_valgrind_stack(stk_seg *stk, uint8_t *sp) {
-#ifndef NVALGRIND
     // Establish that the stack is accessible.  This must be done when reusing
     // old stack segments, since the act of popping the stack previously
     // caused valgrind to consider the whole thing inaccessible.
     assert(sp >= stk->data && sp <= (uint8_t*) stk->end
 	   && "Stack pointer must be inside stack segment");
     size_t sz = stk->end - (uintptr_t)sp;
     VALGRIND_MAKE_MEM_UNDEFINED(sp, sz);
-#endif
 }
 
 void