Skip to content

Commit a8e4301

Browse files
committed
Fix the handling of type params on generic static methods. Closes #7571.
1 parent 052c482 commit a8e4301

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

src/librustc/middle/typeck/collect.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ pub fn ensure_trait_methods(ccx: &CrateCtxt,
278278
// Represents [A',B',C']
279279
let num_trait_bounds = trait_ty_generics.type_param_defs.len();
280280
let non_shifted_trait_tps = do vec::from_fn(num_trait_bounds) |i| {
281-
ty::mk_param(tcx, i, dummy_defid)
281+
ty::mk_param(tcx, i, trait_ty_generics.type_param_defs[i].def_id)
282282
};
283283

284284
// Represents [D']
@@ -288,7 +288,8 @@ pub fn ensure_trait_methods(ccx: &CrateCtxt,
288288
// Represents [E',F',G']
289289
let num_method_bounds = m.generics.type_param_defs.len();
290290
let shifted_method_tps = do vec::from_fn(num_method_bounds) |i| {
291-
ty::mk_param(tcx, i + 1, dummy_defid)
291+
ty::mk_param(tcx, i + num_trait_bounds + 1,
292+
m.generics.type_param_defs[i].def_id)
292293
};
293294

294295
// build up the substitution from
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
trait vec_utils<T> {
12+
fn map_<U:Copy>(x: &Self, f: &fn(&T) -> U) -> ~[U];
13+
}
14+
15+
impl<T> vec_utils<T> for ~[T] {
16+
fn map_<U:Copy>(x: &~[T], f: &fn(&T) -> U) -> ~[U] {
17+
let mut r = ~[];
18+
for x.iter().advance |elt| {
19+
r.push(f(elt));
20+
}
21+
r
22+
}
23+
}
24+
25+
fn main() {
26+
assert_eq!(vec_utils::map_(&~[1,2,3], |&x| x+1), ~[2,3,4]);
27+
}

0 commit comments

Comments
 (0)