Skip to content

Commit a7b311a

Browse files
committed
extra: missed a couple @ in json
1 parent 6818b96 commit a7b311a

File tree

4 files changed

+19
-15
lines changed

4 files changed

+19
-15
lines changed

src/libextra/json.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ impl Json{
464464
pub fn to_pretty_str(&self) -> ~str {
465465
let mut s = MemWriter::new();
466466
self.to_pretty_writer(&mut s as &mut io::Writer);
467-
str::from_utf8(s.inner_ref().as_slice())
467+
str::from_utf8_owned(s.inner())
468468
}
469469
}
470470

@@ -847,7 +847,7 @@ impl<T : Iterator<char>> Parser<T> {
847847

848848
/// Decodes a json value from an `&mut io::Reader`
849849
pub fn from_reader(rdr: &mut io::Reader) -> Result<Json, Error> {
850-
let s = str::from_utf8(rdr.read_to_end());
850+
let s = str::from_utf8_owned(rdr.read_to_end());
851851
let mut parser = Parser::init(s.chars());
852852
parser.parse()
853853
}
@@ -1319,9 +1319,9 @@ impl<A:ToJson> ToJson for Option<A> {
13191319
impl to_str::ToStr for Json {
13201320
/// Encodes a json value into a string
13211321
fn to_str(&self) -> ~str {
1322-
let s = @mut MemWriter::new();
1323-
self.to_writer(s as @mut io::Writer);
1324-
str::from_utf8(s.inner_ref().as_slice())
1322+
let mut s = MemWriter::new();
1323+
self.to_writer(&mut s as &mut io::Writer);
1324+
str::from_utf8_owned(s.inner())
13251325
}
13261326
}
13271327

@@ -1507,14 +1507,14 @@ mod tests {
15071507
assert_eq!(a.clone(), from_str(a.to_pretty_str()).unwrap());
15081508
}
15091509
1510-
fn with_str_writer(f: |@mut io::Writer|) -> ~str {
1510+
fn with_str_writer(f: |&mut io::Writer|) -> ~str {
15111511
use std::io::mem::MemWriter;
15121512
use std::io::Decorator;
15131513
use std::str;
15141514
1515-
let m = @mut MemWriter::new();
1516-
f(m as @mut io::Writer);
1517-
str::from_utf8(*m.inner_ref())
1515+
let mut m = MemWriter::new();
1516+
f(&mut m as &mut io::Writer);
1517+
str::from_utf8_owned(m.inner())
15181518
}
15191519
15201520
#[test]

src/libextra/test.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -945,8 +945,9 @@ impl MetricMap {
945945
/// Load MetricDiff from a file.
946946
pub fn load(p: &Path) -> MetricMap {
947947
assert!(p.exists());
948-
let f = @mut File::open(p) as @mut io::Reader;
949-
let mut decoder = json::Decoder::init(json::from_reader(f).unwrap());
948+
let mut f = File::open(p);
949+
let value = json::from_reader(&mut f as &mut io::Reader).unwrap();
950+
let mut decoder = json::Decoder::init(value);
950951
MetricMap(Decodable::decode(&mut decoder))
951952
}
952953

src/librustdoc/lib.rs

+6-3
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,12 @@ fn json_output(crate: clean::Crate, res: ~[plugins::PluginJson], dst: Path) {
312312
// FIXME #8335: yuck, Rust -> str -> JSON round trip! No way to .encode
313313
// straight to the Rust JSON representation.
314314
let crate_json_str = {
315-
let w = @mut MemWriter::new();
316-
crate.encode(&mut json::Encoder::init(w as @mut io::Writer));
317-
str::from_utf8(*w.inner_ref())
315+
let mut w = MemWriter::new();
316+
{
317+
let mut encoder = json::Encoder::init(&mut w as &mut io::Writer);
318+
crate.encode(&mut encoder);
319+
}
320+
str::from_utf8_owned(w.inner())
318321
};
319322
let crate_json = match json::from_str(crate_json_str) {
320323
Ok(j) => j,

src/libsyntax/parse/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ mod test {
346346
let mut writer = MemWriter::new();
347347
let mut encoder = extra::json::Encoder::init(&mut writer as &mut io::Writer);
348348
val.encode(&mut encoder);
349-
str::from_utf8(*writer.inner_ref())
349+
str::from_utf8_owned(writer.inner())
350350
}
351351

352352
// produce a codemap::span

0 commit comments

Comments
 (0)