features-status-dump: pass key paths via cli flags + misc changes

Author: jieyouxu

Cargo.lock

@@ -1191,6 +1191,8 @@ checksum = "e8c02a5121d4ea3eb16a80748c74f5549a5665e4c21333c6098f283870fbdea6"
 name = "features-status-dump"
 version = "0.1.0"
 dependencies = [
+ "anyhow",
+ "clap",
  "serde",
  "serde_json",
  "tidy",

src/tools/features-status-dump/Cargo.toml

@@ -5,6 +5,8 @@ license = "MIT OR Apache-2.0"
 edition = "2021"
 
 [dependencies]
+anyhow = { version = "1", features = ["backtrace"] }
+clap = { version = "4", features = ["derive"] }
 serde = { version = "1.0.125", features = [ "derive" ] }
 serde_json = "1.0.59"
 tidy = { path = "../tidy" }

src/tools/features-status-dump/src/main.rs

@@ -1,31 +1,53 @@
 use std::collections::HashMap;
-use std::env;
 use std::fs::File;
 use std::io::BufWriter;
-use std::path::Path;
+use std::path::PathBuf;
 
+use anyhow::{Context, Result};
+use clap::Parser;
 use tidy::features::{Feature, collect_lang_features, collect_lib_features};
 
-#[derive(serde::Serialize)]
+#[derive(Debug, Parser)]
+struct Cli {
+    /// Path to `library/` directory.
+    #[arg(long)]
+    library_path: PathBuf,
+    /// Path to `compiler/` directory.
+    #[arg(long)]
+    compiler_path: PathBuf,
+    /// Path to `output/` directory.
+    #[arg(long)]
+    output_path: PathBuf,
+}
+
+#[derive(Debug, serde::Serialize)]
 struct FeaturesStatus {
     lang_features_status: HashMap<String, Feature>,
     lib_features_status: HashMap<String, Feature>,
 }
 
-fn main() {
-    let library_path_str = env::args_os().nth(1).expect("library/ path required");
-    let compiler_path_str = env::args_os().nth(2).expect("compiler/ path required");
-    let output_path_str = env::args_os().nth(3).expect("output path required");
-    let library_path = Path::new(&library_path_str);
-    let compiler_path = Path::new(&compiler_path_str);
-    let output_path = Path::new(&output_path_str);
-    let lang_features_status = collect_lang_features(compiler_path, &mut false);
-    let lib_features_status = collect_lib_features(library_path)
+fn main() -> Result<()> {
+    let Cli { compiler_path, library_path, output_path } = Cli::parse();
+
+    let lang_features_status = collect_lang_features(&compiler_path, &mut false);
+    let lib_features_status = collect_lib_features(&library_path)
         .into_iter()
         .filter(|&(ref name, _)| !lang_features_status.contains_key(name))
         .collect();
     let features_status = FeaturesStatus { lang_features_status, lib_features_status };
-    let writer = File::create(output_path).expect("output path should be a valid path");
-    let writer = BufWriter::new(writer);
-    serde_json::to_writer_pretty(writer, &features_status).unwrap();
+
+    let output_dir = output_path.parent().with_context(|| {
+        format!("failed to get parent dir of output path `{}`", output_path.display())
+    })?;
+    std::fs::create_dir_all(output_dir).with_context(|| {
+        format!("failed to create output directory at `{}`", output_dir.display())
+    })?;
+
+    let output_file = File::create(&output_path).with_context(|| {
+        format!("failed to create file at given output path `{}`", output_path.display())
+    })?;
+    let writer = BufWriter::new(output_file);
+    serde_json::to_writer_pretty(writer, &features_status)
+        .context("failed to write json output")?;
+    Ok(())
 }