Skip to content

Commit 98b07dd

Browse files
committed
Rename task::task_builder to task::builder
Closes #2120.
1 parent 552677e commit 98b07dd

20 files changed

+73
-73
lines changed

src/libcore/task.rs

Lines changed: 51 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export notification;
3030
export sched_mode;
3131
export sched_opts;
3232
export task_opts;
33-
export task_builder::{};
33+
export builder::{};
3434

3535
export default_task_opts;
3636
export get_opts;
@@ -162,8 +162,8 @@ Provides detailed control over the properties and behavior of new tasks.
162162
// when you try to reuse the builder to spawn a new task. We'll just
163163
// sidestep that whole issue by making builder's uncopyable and making
164164
// the run function move them in.
165-
enum task_builder {
166-
task_builder_({
165+
enum builder {
166+
builder_({
167167
mut opts: task_opts,
168168
mut gen_body: fn@(+fn~()) -> fn~(),
169169
can_not_copy: option<comm::port<()>>
@@ -188,27 +188,27 @@ fn default_task_opts() -> task_opts {
188188
}
189189
}
190190

191-
fn task_builder() -> task_builder {
192-
#[doc = "Construct a task_builder"];
191+
fn builder() -> builder {
192+
#[doc = "Construct a builder"];
193193

194194
let body_identity = fn@(+body: fn~()) -> fn~() { body };
195195

196-
task_builder_({
196+
builder_({
197197
mut opts: default_task_opts(),
198198
mut gen_body: body_identity,
199199
can_not_copy: none
200200
})
201201
}
202202

203-
fn get_opts(builder: task_builder) -> task_opts {
204-
#[doc = "Get the task_opts associated with a task_builder"];
203+
fn get_opts(builder: builder) -> task_opts {
204+
#[doc = "Get the task_opts associated with a builder"];
205205

206206
builder.opts
207207
}
208208

209-
fn set_opts(builder: task_builder, opts: task_opts) {
209+
fn set_opts(builder: builder, opts: task_opts) {
210210
#[doc = "
211-
Set the task_opts associated with a task_builder
211+
Set the task_opts associated with a builder
212212
213213
To update a single option use a pattern like the following:
214214
@@ -221,7 +221,7 @@ fn set_opts(builder: task_builder, opts: task_opts) {
221221
builder.opts = opts;
222222
}
223223

224-
fn add_wrapper(builder: task_builder, gen_body: fn@(+fn~()) -> fn~()) {
224+
fn add_wrapper(builder: builder, gen_body: fn@(+fn~()) -> fn~()) {
225225
#[doc = "
226226
Add a wrapper to the body of the spawned task.
227227
@@ -241,7 +241,7 @@ fn add_wrapper(builder: task_builder, gen_body: fn@(+fn~()) -> fn~()) {
241241
};
242242
}
243243

244-
fn run(-builder: task_builder, +f: fn~()) {
244+
fn run(-builder: builder, +f: fn~()) {
245245
#[doc = "
246246
Creates and exucutes a new child task
247247
@@ -262,7 +262,7 @@ fn run(-builder: task_builder, +f: fn~()) {
262262

263263
/* Builder convenience functions */
264264

265-
fn future_result(builder: task_builder) -> future::future<task_result> {
265+
fn future_result(builder: builder) -> future::future<task_result> {
266266
#[doc = "
267267
Get a future representing the exit status of the task.
268268
@@ -295,7 +295,7 @@ fn future_result(builder: task_builder) -> future::future<task_result> {
295295
}
296296
}
297297

298-
fn future_task(builder: task_builder) -> future::future<task> {
298+
fn future_task(builder: builder) -> future::future<task> {
299299
#[doc = "Get a future representing the handle to the new task"];
300300

301301
let mut po = comm::port();
@@ -309,7 +309,7 @@ fn future_task(builder: task_builder) -> future::future<task> {
309309
future::from_port(po)
310310
}
311311

312-
fn unsupervise(builder: task_builder) {
312+
fn unsupervise(builder: builder) {
313313
#[doc = "Configures the new task to not propagate failure to its parent"];
314314

315315
set_opts(builder, {
@@ -318,7 +318,7 @@ fn unsupervise(builder: task_builder) {
318318
});
319319
}
320320

321-
fn run_listener<A:send>(-builder: task_builder,
321+
fn run_listener<A:send>(-builder: builder,
322322
+f: fn~(comm::port<A>)) -> comm::chan<A> {
323323
#[doc = "
324324
Runs a new task while providing a channel from the parent to the child
@@ -355,10 +355,10 @@ fn spawn(+f: fn~()) {
355355
Sets up a new task with its own call stack and schedules it to run
356356
the provided unique closure.
357357
358-
This function is equivalent to `run(new_task_builder(), f)`.
358+
This function is equivalent to `run(new_builder(), f)`.
359359
"];
360360

361-
run(task_builder(), f);
361+
run(builder(), f);
362362
}
363363

364364
fn spawn_listener<A:send>(+f: fn~(comm::port<A>)) -> comm::chan<A> {
@@ -384,10 +384,10 @@ fn spawn_listener<A:send>(+f: fn~(comm::port<A>)) -> comm::chan<A> {
384384
};
385385
// Likewise, the parent has both a 'po' and 'ch'
386386
387-
This function is equivalent to `run_listener(new_task_builder(), f)`.
387+
This function is equivalent to `run_listener(new_builder(), f)`.
388388
"];
389389

390-
run_listener(task_builder(), f)
390+
run_listener(builder(), f)
391391
}
392392

393393
fn spawn_sched(mode: sched_mode, +f: fn~()) {
@@ -404,7 +404,7 @@ fn spawn_sched(mode: sched_mode, +f: fn~()) {
404404
greater than zero.
405405
"];
406406

407-
let mut builder = task_builder();
407+
let mut builder = builder();
408408
set_opts(builder, {
409409
sched: some({
410410
mode: mode,
@@ -429,7 +429,7 @@ fn try<T:send>(+f: fn~() -> T) -> result<T,()> {
429429

430430
let po = comm::port();
431431
let ch = comm::chan(po);
432-
let mut builder = task_builder();
432+
let mut builder = builder();
433433
unsupervise(builder);
434434
let result = future_result(builder);
435435
run(builder) {||
@@ -626,8 +626,8 @@ fn test_spawn_raw_notify() {
626626
fn test_run_basic() {
627627
let po = comm::port();
628628
let ch = comm::chan(po);
629-
let builder = task_builder();
630-
run(builder) {||
629+
let buildr = builder();
630+
run(buildr) {||
631631
comm::send(ch, ());
632632
}
633633
comm::recv(po);
@@ -637,39 +637,39 @@ fn test_run_basic() {
637637
fn test_add_wrapper() {
638638
let po = comm::port();
639639
let ch = comm::chan(po);
640-
let builder = task_builder();
641-
add_wrapper(builder) {|body|
640+
let buildr = builder();
641+
add_wrapper(buildr) {|body|
642642
fn~() {
643643
body();
644644
comm::send(ch, ());
645645
}
646646
}
647-
run(builder) {||}
647+
run(buildr) {||}
648648
comm::recv(po);
649649
}
650650

651651
#[test]
652652
#[ignore(cfg(target_os = "win32"))]
653653
fn test_future_result() {
654-
let builder = task_builder();
655-
let result = future_result(builder);
656-
run(builder) {||}
654+
let buildr = builder();
655+
let result = future_result(buildr);
656+
run(buildr) {||}
657657
assert future::get(result) == success;
658658

659-
let builder = task_builder();
660-
let result = future_result(builder);
661-
unsupervise(builder);
662-
run(builder) {|| fail }
659+
let buildr = builder();
660+
let result = future_result(buildr);
661+
unsupervise(buildr);
662+
run(buildr) {|| fail }
663663
assert future::get(result) == failure;
664664
}
665665

666666
#[test]
667667
fn test_future_task() {
668668
let po = comm::port();
669669
let ch = comm::chan(po);
670-
let builder = task_builder();
671-
let task1 = future_task(builder);
672-
run(builder) {|| comm::send(ch, get_task()) }
670+
let buildr = builder();
671+
let task1 = future_task(buildr);
672+
run(buildr) {|| comm::send(ch, get_task()) }
673673
assert future::get(task1) == comm::recv(po);
674674
}
675675

@@ -863,8 +863,8 @@ fn test_avoid_copying_the_body_spawn_listener() {
863863
#[test]
864864
fn test_avoid_copying_the_body_run() {
865865
avoid_copying_the_body {|f|
866-
let builder = task_builder();
867-
run(builder) {||
866+
let buildr = builder();
867+
run(buildr) {||
868868
f();
869869
}
870870
}
@@ -873,8 +873,8 @@ fn test_avoid_copying_the_body_run() {
873873
#[test]
874874
fn test_avoid_copying_the_body_run_listener() {
875875
avoid_copying_the_body {|f|
876-
let builder = task_builder();
877-
run_listener(builder, fn~[move f](_po: comm::port<int>) {
876+
let buildr = builder();
877+
run_listener(buildr, fn~[move f](_po: comm::port<int>) {
878878
f();
879879
});
880880
}
@@ -892,9 +892,9 @@ fn test_avoid_copying_the_body_try() {
892892
#[test]
893893
fn test_avoid_copying_the_body_future_task() {
894894
avoid_copying_the_body {|f|
895-
let builder = task_builder();
896-
future_task(builder);
897-
run(builder) {||
895+
let buildr = builder();
896+
future_task(buildr);
897+
run(buildr) {||
898898
f();
899899
}
900900
}
@@ -903,29 +903,29 @@ fn test_avoid_copying_the_body_future_task() {
903903
#[test]
904904
fn test_avoid_copying_the_body_unsupervise() {
905905
avoid_copying_the_body {|f|
906-
let builder = task_builder();
907-
unsupervise(builder);
908-
run(builder) {||
906+
let buildr = builder();
907+
unsupervise(buildr);
908+
run(buildr) {||
909909
f();
910910
}
911911
}
912912
}
913913

914914
#[test]
915915
fn test_osmain() {
916-
let builder = task_builder();
916+
let buildr = builder();
917917
let opts = {
918918
sched: some({
919919
mode: osmain,
920920
native_stack_size: none
921921
})
922-
with get_opts(builder)
922+
with get_opts(buildr)
923923
};
924-
set_opts(builder, opts);
924+
set_opts(buildr, opts);
925925

926926
let po = comm::port();
927927
let ch = comm::chan(po);
928-
run(builder) {||
928+
run(buildr) {||
929929
comm::send(ch, ());
930930
}
931931
comm::recv(po);

src/libstd/test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ fn run_test(+test: test_desc, monitor_ch: comm::chan<monitor_msg>) {
390390

391391
task::spawn {||
392392
let testfn = test.fn;
393-
let mut builder = task::task_builder();
393+
let mut builder = task::builder();
394394
let result_future = task::future_result(builder);
395395
task::unsupervise(builder);
396396
task::run(builder, testfn);

src/test/bench/msgsend.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ fn run(args: [str]) {
3939
let to_child = to_child;
4040
let mut worker_results = [];
4141
uint::range(0u, workers) {|_i|
42-
let builder = task::task_builder();
42+
let builder = task::builder();
4343
worker_results += [task::future_result(builder)];
4444
task::run(builder) {||
4545
uint::range(0u, size / workers) {|_i|

src/test/bench/shootout-pfib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ fn stress_task(&&id: int) {
7171
fn stress(num_tasks: int) {
7272
let mut results = [];
7373
range(0, num_tasks) {|i|
74-
let builder = task::task_builder();
74+
let builder = task::builder();
7575
results += [task::future_result(builder)];
7676
task::run(builder) {|| stress_task(i); }
7777
}

src/test/bench/task-perf-word-count.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ mod map_reduce {
6262
[future::future<task::task_result>] {
6363
let mut results = [];
6464
for i: str in inputs {
65-
let builder = task::task_builder();
65+
let builder = task::builder();
6666
results += [task::future_result(builder)];
6767
task::run(builder) {|| map_task(ctrl, i)}
6868
}
@@ -160,7 +160,7 @@ mod map_reduce {
160160
// log(error, "creating new reducer for " + k);
161161
let p = port();
162162
let ch = chan(p);
163-
let builder = task::task_builder();
163+
let builder = task::builder();
164164
results += [task::future_result(builder)];
165165
task::run(builder) {||reduce_task(k, ch)}
166166
c = recv(p);

src/test/run-pass/lots-a-fail.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ fn iloop() {
1414

1515
fn main() {
1616
uint::range(0u, 100u) {|_i|
17-
let builder = task::task_builder();
17+
let builder = task::builder();
1818
task::unsupervise(builder);
1919
task::run(builder) {|| iloop(); };
2020
}

src/test/run-pass/osmain.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ fn run(i: int) {
1414
ret;
1515
}
1616

17-
let builder = task::task_builder();
17+
let builder = task::builder();
1818
let opts = {
1919
sched: some({
2020
mode: task::osmain,
@@ -26,7 +26,7 @@ fn run(i: int) {
2626
task::unsupervise(builder);
2727
task::run(builder) {||
2828
task::yield();
29-
let builder = task::task_builder();
29+
let builder = task::builder();
3030
let opts = {
3131
sched: some({
3232
mode: task::single_threaded,

src/test/run-pass/send-iloop.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ fn iloop() {
2222

2323
fn main() {
2424
uint::range(0u, 16u) {|_i|
25-
let builder = task::task_builder();
25+
let builder = task::builder();
2626
task::unsupervise(builder);
2727
task::run(builder) {|| iloop(); }
2828
}

src/test/run-pass/task-comm-12.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ fn start(&&task_number: int) { #debug("Started / Finished task."); }
77

88
fn test00() {
99
let i: int = 0;
10-
let builder = task::task_builder();
10+
let builder = task::builder();
1111
let r = task::future_result(builder);
1212
task::run(builder) {|| start(i); };
1313

src/test/run-pass/task-comm-3.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ fn test00() {
3232
// Create and spawn tasks...
3333
let mut results = [];
3434
while i < number_of_tasks {
35-
let builder = task::task_builder();
35+
let builder = task::builder();
3636
results += [task::future_result(builder)];
3737
task::run(builder) {||
3838
test00_start(ch, i, number_of_messages)

src/test/run-pass/task-comm-9.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ fn test00() {
1616
let number_of_messages: int = 10;
1717
let ch = comm::chan(p);
1818

19-
let builder = task::task_builder();
19+
let builder = task::builder();
2020
let r = task::future_result(builder);
2121
task::run(builder) {||
2222
test00_start(ch, number_of_messages);

0 commit comments

Comments
 (0)