Skip to content

Commit 8ab795e

Browse files
committed
add a summary, in addition to the link
1 parent 225e01e commit 8ab795e

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

compiler/rustc_codegen_llvm/src/context.rs

+5-2
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,13 @@ pub unsafe fn create_module<'ll>(
145145
let llvm_version = llvm_util::get_version();
146146
if llvm_version < (16, 0, 0) {
147147
if sess.target.arch == "s390x" {
148-
// See https://reviews.llvm.org/D131158
148+
// LLVM 16 data layout changed to always set 64-bit vector alignment,
149+
// which is conditional in earlier LLVM versions.
150+
// https://reviews.llvm.org/D131158 for the discussion.
149151
target_data_layout = target_data_layout.replace("-v128:64", "");
150152
} else if sess.target.arch == "riscv64" {
151-
// See https://reviews.llvm.org/D116735
153+
// LLVM 16 introduced this change so as to produce more efficient code.
154+
// See https://reviews.llvm.org/D116735 for the discussion.
152155
target_data_layout = target_data_layout.replace("-n32:64-", "-n64-");
153156
}
154157
}

0 commit comments

Comments
 (0)