rustdoc: Remove structural records from tests. Fixes build breakage

Author: catamorphism

src/librustdoc/attr_pass.rs

@@ -70,13 +70,13 @@ fn fold_crate(
     };
 
     doc::CrateDoc {
-        topmod: doc::ModDoc_(doc::ModDoc_ {
+        topmod: doc::ModDoc {
             item: doc::ItemDoc {
                 name: option::get_or_default(attrs.name, doc.topmod.name()),
                 .. doc.topmod.item
             },
-            .. *doc.topmod
-        })
+            .. doc.topmod
+        }
     }
 }
 

src/librustdoc/config.rs

@@ -256,7 +256,7 @@ fn maybe_find_pandoc(
 
 #[test]
 fn should_find_pandoc() {
-    let config = {
+    let config = Config {
         output_format: PandocHtml,
         .. default_config(&Path("test"))
     };
@@ -273,7 +273,7 @@ fn should_find_pandoc() {
 
 #[test]
 fn should_error_with_no_pandoc() {
-    let config = {
+    let config = Config {
         output_format: PandocHtml,
         .. default_config(&Path("test"))
     };

src/librustdoc/doc.rs

@@ -22,15 +22,10 @@ use core::vec;
 pub type AstId = int;
 
 #[deriving_eq]
-pub struct Doc_ {
+pub struct Doc {
     pages: ~[Page]
 }
 
-#[deriving_eq]
-pub enum Doc {
-    Doc_(Doc_)
-}
-
 #[deriving_eq]
 pub enum Page {
     CratePage(CrateDoc),
@@ -93,17 +88,12 @@ pub struct SimpleItemDoc {
 }
 
 #[deriving_eq]
-pub struct ModDoc_ {
+pub struct ModDoc {
     item: ItemDoc,
     items: ~[ItemTag],
     index: Option<Index>
 }
 
-#[deriving_eq]
-pub enum ModDoc {
-    ModDoc_(ModDoc_)
-}
-
 #[deriving_eq]
 pub struct NmodDoc {
     item: ItemDoc,

src/librustdoc/extract.rs

@@ -57,13 +57,13 @@ pub fn extract(
     crate: @ast::crate,
     +default_name: ~str
 ) -> doc::Doc {
-    doc::Doc_(doc::Doc_ {
+    doc::Doc {
         pages: ~[
             doc::CratePage(doc::CrateDoc {
                 topmod: top_moddoc_from_crate(crate, default_name),
             })
         ]
-    })
+    }
 }
 
 fn top_moddoc_from_crate(
@@ -90,7 +90,7 @@ fn moddoc_from_mod(
     +itemdoc: doc::ItemDoc,
     module_: ast::_mod
 ) -> doc::ModDoc {
-    doc::ModDoc_(doc::ModDoc_ {
+    doc::ModDoc {
         item: itemdoc,
         items: do vec::filter_map(module_.items) |item| {
             let ItemDoc = mk_itemdoc(item.id, to_str(item.ident));
@@ -144,7 +144,7 @@ fn moddoc_from_mod(
             }
         },
         index: None
-    })
+    }
 }
 
 fn nmoddoc_from_mod(

src/librustdoc/fold.rs

@@ -158,7 +158,7 @@ pub fn default_par_fold<T:Owned Clone>(+ctxt: T) -> Fold<T> {
 }
 
 pub fn default_seq_fold_doc<T>(fold: &Fold<T>, +doc: doc::Doc) -> doc::Doc {
-    doc::Doc_(doc::Doc_ {
+    doc::Doc {
         pages: do vec::map(doc.pages) |page| {
             match *page {
               doc::CratePage(doc) => {
@@ -169,8 +169,8 @@ pub fn default_seq_fold_doc<T>(fold: &Fold<T>, +doc: doc::Doc) -> doc::Doc {
               }
             }
         },
-        .. *doc
-    })
+        .. doc
+    }
 }
 
 pub fn default_seq_fold_crate<T>(
@@ -194,40 +194,40 @@ pub fn default_any_fold_mod<T:Owned Clone>(
     +doc: doc::ModDoc
 ) -> doc::ModDoc {
     let fold_copy = fold.clone();
-    doc::ModDoc_(doc::ModDoc_ {
+    doc::ModDoc {
         item: (fold.fold_item)(fold, doc.item),
         items: par::map(doc.items, |ItemTag, move fold_copy| {
             fold_ItemTag(&fold_copy, *ItemTag)
         }),
-        .. *doc
-    })
+        .. doc
+    }
 }
 
 pub fn default_seq_fold_mod<T>(
     fold: &Fold<T>,
     +doc: doc::ModDoc
 ) -> doc::ModDoc {
-    doc::ModDoc_(doc::ModDoc_ {
+    doc::ModDoc {
         item: (fold.fold_item)(fold, doc.item),
         items: vec::map(doc.items, |ItemTag| {
             fold_ItemTag(fold, *ItemTag)
         }),
-        .. *doc
-    })
+        .. doc
+    }
 }
 
 pub fn default_par_fold_mod<T:Owned Clone>(
     fold: &Fold<T>,
     +doc: doc::ModDoc
 ) -> doc::ModDoc {
     let fold_copy = fold.clone();
-    doc::ModDoc_(doc::ModDoc_ {
+    doc::ModDoc {
         item: (fold.fold_item)(fold, doc.item),
         items: par::map(doc.items, |ItemTag, move fold_copy| {
             fold_ItemTag(&fold_copy, *ItemTag)
         }),
-        .. *doc
-    })
+        .. doc
+    }
 }
 
 pub fn default_any_fold_nmod<T:Owned Clone>(

src/librustdoc/markdown_index_pass.rs

@@ -54,10 +54,10 @@ fn fold_mod(
 
     let doc = fold::default_any_fold_mod(fold, doc);
 
-    doc::ModDoc_(doc::ModDoc_ {
+    doc::ModDoc {
         index: Some(build_mod_index(doc, fold.ctxt)),
-        .. *doc
-    })
+        .. doc
+    }
 }
 
 fn fold_nmod(
@@ -180,13 +180,13 @@ fn should_index_mod_contents() {
         config::DocPerCrate,
         ~"mod a { } fn b() { }"
     );
-    assert doc.cratemod().index.get().entries[0] == {
+    assert doc.cratemod().index.get().entries[0] == doc::IndexEntry {
         kind: ~"Module",
         name: ~"a",
         brief: None,
         link: ~"#module-a"
     };
-    assert doc.cratemod().index.get().entries[1] == {
+    assert doc.cratemod().index.get().entries[1] == doc::IndexEntry {
         kind: ~"Function",
         name: ~"b",
         brief: None,
@@ -200,13 +200,13 @@ fn should_index_mod_contents_multi_page() {
         config::DocPerMod,
         ~"mod a { } fn b() { }"
     );
-    assert doc.cratemod().index.get().entries[0] == {
+    assert doc.cratemod().index.get().entries[0] == doc::IndexEntry {
         kind: ~"Module",
         name: ~"a",
         brief: None,
         link: ~"a.html"
     };
-    assert doc.cratemod().index.get().entries[1] == {
+    assert doc.cratemod().index.get().entries[1] == doc::IndexEntry {
         kind: ~"Function",
         name: ~"b",
         brief: None,
@@ -220,7 +220,7 @@ fn should_index_foreign_mod_pages() {
         config::DocPerMod,
         ~"extern mod a { }"
     );
-    assert doc.cratemod().index.get().entries[0] == {
+    assert doc.cratemod().index.get().entries[0] == doc::IndexEntry {
         kind: ~"Foreign module",
         name: ~"a",
         brief: None,
@@ -244,7 +244,8 @@ fn should_index_foreign_mod_contents() {
         config::DocPerCrate,
         ~"extern mod a { fn b(); }"
     );
-    assert doc.cratemod().nmods()[0].index.get().entries[0] == {
+    assert doc.cratemod().nmods()[0].index.get().entries[0]
+        == doc::IndexEntry {
         kind: ~"Function",
         name: ~"b",
         brief: None,
@@ -268,7 +269,7 @@ mod test {
     pub fn mk_doc(output_style: config::OutputStyle, +source: ~str)
                -> doc::Doc {
         do astsrv::from_str(source) |srv| {
-            let config = {
+            let config = config::Config {
                 output_style: output_style,
                 .. config::default_config(&Path("whatever"))
             };

src/librustdoc/markdown_pass.rs

@@ -573,20 +573,20 @@ fn should_insert_blank_line_after_fn_signature() {
 #[test]
 fn should_correctly_indent_fn_signature() {
     let doc = test::create_doc(~"fn a() { }");
-    let doc = doc::Doc_({
+    let doc = doc::Doc{
         pages: ~[
-            doc::CratePage({
-                topmod: doc::ModDoc_({
-                    items: ~[doc::FnTag({
+            doc::CratePage(doc::CrateDoc{
+                topmod: doc::ModDoc{
+                    items: ~[doc::FnTag(doc::SimpleItemDoc{
                         sig: Some(~"line 1\nline 2"),
                         .. doc.cratemod().fns()[0]
                     })],
-                    .. *doc.cratemod()
-                }),
+                    .. doc.cratemod()
+                },
                 .. doc.CrateDoc()
             })
         ]
-    });
+    };
     let markdown = test::write_markdown_str(doc);
     assert str::contains(markdown, ~"    line 1\n    line 2");
 }
@@ -863,7 +863,7 @@ mod test {
     fn create_doc_srv(+source: ~str) -> (astsrv::Srv, doc::Doc) {
         do astsrv::from_str(source) |srv| {
 
-            let config = {
+            let config = config::Config {
                 output_style: config::DocPerCrate,
                 .. config::default_config(&Path("whatever"))
             };

src/librustdoc/markdown_writer.rs

@@ -11,6 +11,7 @@
 use core::prelude::*;
 
 use config;
+use config::Config;
 use doc::ItemUtils;
 use doc;
 use pass::Pass;
@@ -228,7 +229,7 @@ pub fn make_filename(
 
 #[test]
 fn should_use_markdown_file_name_based_off_crate() {
-    let config = {
+    let config = Config {
         output_dir: Path("output/dir"),
         output_format: config::Markdown,
         output_style: config::DocPerCrate,
@@ -242,7 +243,7 @@ fn should_use_markdown_file_name_based_off_crate() {
 
 #[test]
 fn should_name_html_crate_file_name_index_html_when_doc_per_mod() {
-    let config = {
+    let config = Config {
         output_dir: Path("output/dir"),
         output_format: config::PandocHtml,
         output_style: config::DocPerMod,
@@ -256,7 +257,7 @@ fn should_name_html_crate_file_name_index_html_when_doc_per_mod() {
 
 #[test]
 fn should_name_mod_file_names_by_path() {
-    let config = {
+    let config = Config {
         output_dir: Path("output/dir"),
         output_format: config::PandocHtml,
         output_style: config::DocPerMod,

src/librustdoc/page_pass.rs

@@ -76,9 +76,9 @@ fn make_doc_from_pages(page_port: PagePort) -> doc::Doc {
             break;
         }
     }
-    doc::Doc_(doc::Doc_ {
+    doc::Doc {
         pages: pages
-    })
+    }
 }
 
 fn find_pages(doc: doc::Doc, page_chan: PageChan) {
@@ -128,16 +128,16 @@ fn fold_mod(
 }
 
 fn strip_mod(doc: doc::ModDoc) -> doc::ModDoc {
-    doc::ModDoc_(doc::ModDoc_ {
+    doc::ModDoc {
         items: do doc.items.filtered |item| {
             match *item {
               doc::ModTag(_) => false,
               doc::NmodTag(_) => false,
               _ => true
             }
         },
-        .. *doc
-    })
+        .. doc
+    }
 }
 
 fn fold_nmod(