Skip to content

Commit 7f7e216

Browse files
committed
Rename some variables.
These make the delimiter processing clearer.
1 parent 880ebb6 commit 7f7e216

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

Diff for: compiler/rustc_parse/src/lexer/tokentrees.rs

+10-10
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,12 @@ impl<'a> TokenTreesReader<'a> {
110110
err
111111
}
112112

113-
fn parse_token_tree_open_delim(&mut self, delim: Delimiter) -> TokenTree {
113+
fn parse_token_tree_open_delim(&mut self, open_delim: Delimiter) -> TokenTree {
114114
// The span for beginning of the delimited section
115115
let pre_span = self.token.span;
116116

117117
// Move past the open delimiter.
118-
self.open_braces.push((delim, self.token.span));
118+
self.open_braces.push((open_delim, self.token.span));
119119
self.token = self.string_reader.next_token().0;
120120

121121
// Parse the token trees within the delimiters.
@@ -128,7 +128,7 @@ impl<'a> TokenTreesReader<'a> {
128128

129129
match self.token.kind {
130130
// Correct delimiter.
131-
token::CloseDelim(d) if d == delim => {
131+
token::CloseDelim(close_delim) if close_delim == open_delim => {
132132
let (open_brace, open_brace_span) = self.open_braces.pop().unwrap();
133133
let close_brace_span = self.token.span;
134134

@@ -138,12 +138,12 @@ impl<'a> TokenTreesReader<'a> {
138138
if !sm.is_multiline(empty_block_span) {
139139
// Only track if the block is in the form of `{}`, otherwise it is
140140
// likely that it was written on purpose.
141-
self.last_delim_empty_block_spans.insert(delim, empty_block_span);
141+
self.last_delim_empty_block_spans.insert(open_delim, empty_block_span);
142142
}
143143
}
144144

145145
//only add braces
146-
if let (Delimiter::Brace, Delimiter::Brace) = (open_brace, delim) {
146+
if let (Delimiter::Brace, Delimiter::Brace) = (open_brace, open_delim) {
147147
self.matching_block_spans.push((open_brace_span, close_brace_span));
148148
}
149149

@@ -158,7 +158,7 @@ impl<'a> TokenTreesReader<'a> {
158158
self.token = self.string_reader.next_token().0;
159159
}
160160
// Incorrect delimiter.
161-
token::CloseDelim(other) => {
161+
token::CloseDelim(close_delim) => {
162162
let mut unclosed_delimiter = None;
163163
let mut candidate = None;
164164

@@ -176,7 +176,7 @@ impl<'a> TokenTreesReader<'a> {
176176
for (brace, brace_span) in &self.open_braces {
177177
if let Some(padding) = sm.span_to_margin(*brace_span) {
178178
// high likelihood of these two corresponding
179-
if current_padding == padding && brace == &other {
179+
if current_padding == padding && brace == &close_delim {
180180
candidate = Some(*brace_span);
181181
}
182182
}
@@ -185,7 +185,7 @@ impl<'a> TokenTreesReader<'a> {
185185
let (tok, _) = self.open_braces.pop().unwrap();
186186
self.unmatched_braces.push(UnmatchedBrace {
187187
expected_delim: tok,
188-
found_delim: Some(other),
188+
found_delim: Some(close_delim),
189189
found_span: self.token.span,
190190
unclosed_span: unclosed_delimiter,
191191
candidate_span: candidate,
@@ -201,7 +201,7 @@ impl<'a> TokenTreesReader<'a> {
201201
// fn foo() {
202202
// bar(baz(
203203
// } // Incorrect delimiter but matches the earlier `{`
204-
if !self.open_braces.iter().any(|&(b, _)| b == other) {
204+
if !self.open_braces.iter().any(|&(b, _)| b == close_delim) {
205205
self.token = self.string_reader.next_token().0;
206206
}
207207
}
@@ -213,7 +213,7 @@ impl<'a> TokenTreesReader<'a> {
213213
_ => unreachable!(),
214214
}
215215

216-
TokenTree::Delimited(delim_span, delim, tts)
216+
TokenTree::Delimited(delim_span, open_delim, tts)
217217
}
218218

219219
fn close_delim_err(&mut self, delim: Delimiter) -> PErr<'a> {

0 commit comments

Comments
 (0)