Skip to content

Commit 7ba18da

Browse files
authored
Merge pull request #19009 from lnicola/dont-just-die
minor: Rephrase comment
2 parents 3ca1066 + a32f64d commit 7ba18da

File tree

1 file changed

+3
-3
lines changed
  • src/tools/rust-analyzer/lib/lsp-server/src

1 file changed

+3
-3
lines changed

src/tools/rust-analyzer/lib/lsp-server/src/msg.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,9 @@ pub struct Request {
8080

8181
#[derive(Debug, Serialize, Deserialize, Clone)]
8282
pub struct Response {
83-
// JSON RPC allows this to be null if it was impossible
84-
// to decode the request's id. Ignore this special case
85-
// and just die horribly.
83+
// JSON-RPC allows this to be null if we can't find or parse the
84+
// request id. We fail deserialization in that case, so we just
85+
// make this field mandatory.
8686
pub id: RequestId,
8787
#[serde(skip_serializing_if = "Option::is_none")]
8888
pub result: Option<serde_json::Value>,

0 commit comments

Comments
 (0)