Skip to content

Commit 784bffe

Browse files
author
Clark Gaebel
committed
---
yaml --- r: 111423 b: refs/heads/master c: 9f45484 h: refs/heads/master i: 111421: 730e475 111419: 69f5f0a 111415: e0bba37 111407: b6e0b41 111391: 46a4ea8 111359: 7b37193 v: v3
1 parent b4baf89 commit 784bffe

File tree

413 files changed

+3124
-3649
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

413 files changed

+3124
-3649
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: c7553ea17359cad2c8d30855380f78026127f7b7
2+
refs/heads/master: 9f45484db5cc4570b4e489e82646efc5c628b6ea
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: b5dd3f05fe95168b5569d0f519636149479eb6ac
55
refs/heads/try: 38201d7c6bf0c32b0e5bdc8ecd63976ebc1b3a4c

trunk/configure

Lines changed: 23 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,6 @@ opt ccache 0 "invoke gcc/clang via ccache to reuse object files between builds"
388388
opt local-rust 0 "use an installed rustc rather than downloading a snapshot"
389389
opt pax-flags 0 "apply PaX flags to rustc binaries (required for GRSecurity/PaX-patched kernels)"
390390
opt inject-std-version 1 "inject the current compiler version of libstd into programs"
391-
opt llvm-static-stdcpp 0 "statically link to libstdc++ for LLVM"
392391
opt rpath 1 "build rpaths into rustc itself"
393392
opt nightly 0 "build nightly packages"
394393
opt verify-install 1 "verify installed binaries work"
@@ -580,32 +579,26 @@ then
580579
CFG_ENABLE_CLANG=1
581580
putvar CFG_ENABLE_CLANG
582581
else
583-
if [ $("$CFG_GCC" --version 2>&1 | grep -c ' 4\.[0-6]') -ne 0 ]; then
584-
step_msg "older GCC found, using clang instead"
585-
CFG_ENABLE_CLANG=1
586-
putvar CFG_ENABLE_CLANG
587-
else
588-
# on OS X, with xcode 5 and newer, certain developers may have
589-
# cc, gcc and g++ point to a mixture of clang and gcc
590-
# if so, this will create very strange build errors
591-
# this last stanza is to detect some such problems and save the future rust
592-
# contributor some time solving that issue.
593-
# this detection could be generalized to other OSes aside from OS X
594-
# but the issue seems most likely to happen on OS X
595-
596-
chk_cc () {
597-
$1 --version 2> /dev/null | grep -q $2
598-
}
599-
# check that gcc, cc and g++ all point to the same compiler.
600-
# note that for xcode 5, g++ points to clang, not clang++
601-
if !((chk_cc gcc clang && chk_cc g++ clang) ||
602-
(chk_cc gcc gcc &&( chk_cc g++ g++ || chk g++ gcc))) then
603-
err "the gcc and g++ in your path point to different compilers.
604-
Check which versions are in your path with cc --version and g++ --version.
605-
To resolve this problem, either fix your PATH or run configure with --enable-clang"
606-
fi
607-
582+
# on OS X, with xcode 5 and newer, certain developers may have
583+
# cc, gcc and g++ point to a mixture of clang and gcc
584+
# if so, this will create very strange build errors
585+
# this last stanza is to detect some such problems and save the future rust
586+
# contributor some time solving that issue.
587+
# this detection could be generalized to other OSes aside from OS X
588+
# but the issue seems most likely to happen on OS X
589+
590+
chk_cc () {
591+
$1 --version 2> /dev/null | grep -q $2
592+
}
593+
# check that gcc, cc and g++ all point to the same compiler.
594+
# note that for xcode 5, g++ points to clang, not clang++
595+
if !((chk_cc gcc clang && chk_cc g++ clang) ||
596+
(chk_cc gcc gcc &&( chk_cc g++ g++ || chk g++ gcc))) then
597+
err "the gcc and g++ in your path point to different compilers.
598+
Check which versions are in your path with cc --version and g++ --version.
599+
To resolve this problem, either fix your PATH or run configure with --enable-clang"
608600
fi
601+
609602
fi
610603
fi
611604

@@ -928,6 +921,10 @@ do
928921
LLVM_OPTS="$LLVM_OPTS --disable-terminfo"
929922
# Try to have LLVM pull in as few dependencies as possible (#9397)
930923
LLVM_OPTS="$LLVM_OPTS --disable-zlib --disable-libffi"
924+
# LLVM says it needs a "new" clang/gcc, but we seem to get by ok with
925+
# older versions on the bots. Get by for a little longer by asking it to
926+
# not do version detection
927+
LLVM_OPTS="$LLVM_OPTS --disable-compiler-version-checks"
931928

932929
# Use win32 native thread/lock apis instead of pthread wrapper.
933930
# (llvm's configure tries to find pthread first, so we have to disable it explicitly.)
@@ -945,15 +942,13 @@ do
945942

946943
LLVM_CXX_64="ccache clang++ -Qunused-arguments"
947944
LLVM_CC_64="ccache clang -Qunused-arguments"
948-
LLVM_OPTS="$LLVM_OPTS --enable-libcpp"
949945
;;
950946
("clang")
951947
LLVM_CXX_32="clang++ -m32 -Qunused-arguments"
952948
LLVM_CC_32="clang -m32 -Qunused-arguments"
953949

954950
LLVM_CXX_64="clang++ -Qunused-arguments"
955951
LLVM_CC_64="clang -Qunused-arguments"
956-
LLVM_OPTS="$LLVM_OPTS --enable-libcpp"
957952
;;
958953
("ccache gcc")
959954
LLVM_CXX_32="ccache g++ -m32"

trunk/mk/llvm.mk

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,25 +42,16 @@ $$(LLVM_STAMP_$(1)): $(S)src/rustllvm/llvm-auto-clean-trigger
4242
@$$(call E, make: done cleaning llvm)
4343
touch $$@
4444

45-
ifeq ($$(CFG_ENABLE_LLVM_STATIC_STDCPP),1)
46-
LLVM_STDCPP_LOCATION_$(1) = $$(shell $$(CC_$(1)) $$(CFG_GCCISH_CFLAGS_$(1)) \
47-
-print-file-name=libstdc++.a)
48-
else
49-
LLVM_STDCPP_LOCATION_$(1) =
50-
endif
51-
5245
endef
5346

5447
$(foreach host,$(CFG_HOST), \
55-
$(eval $(call DEF_LLVM_RULES,$(host))))
48+
$(eval LLVM_CONFIGS := $(LLVM_CONFIGS) $(LLVM_CONFIG_$(host))))
5649

5750
$(foreach host,$(CFG_HOST), \
58-
$(eval LLVM_CONFIGS := $(LLVM_CONFIGS) $(LLVM_CONFIG_$(host))))
51+
$(eval $(call DEF_LLVM_RULES,$(host))))
5952

6053
$(S)src/librustc/lib/llvmdeps.rs: \
6154
$(LLVM_CONFIGS) \
62-
$(S)src/etc/mklldeps.py \
63-
$(MKFILE_DEPS)
55+
$(S)src/etc/mklldeps.py
6456
$(Q)$(CFG_PYTHON) $(S)src/etc/mklldeps.py \
65-
"$@" "$(LLVM_COMPONENTS)" "$(CFG_ENABLE_LLVM_STATIC_STDCPP)" \
66-
$(LLVM_CONFIGS)
57+
"$@" "$(LLVM_COMPONENTS)" $(LLVM_CONFIGS)

trunk/mk/target.mk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ $$(TLIB$(1)_T_$(2)_H_$(3))/stamp.$(4): \
8383
$$(WFLAGS_ST$(1)) \
8484
-L "$$(RT_OUTPUT_DIR_$(2))" \
8585
-L "$$(LLVM_LIBDIR_$(2))" \
86-
-L "$$(dir $$(LLVM_STDCPP_LOCATION_$(2)))" \
8786
--out-dir $$(@D) $$<
8887
@touch $$@
8988
$$(call LIST_ALL_OLD_GLOB_MATCHES,\

trunk/src/compiletest/compiletest.rs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ pub fn parse_config(args: Vec<~str> ) -> config {
9393
assert!(!args.is_empty());
9494
let argv0 = (*args.get(0)).clone();
9595
let args_ = args.tail();
96-
if *args.get(1) == "-h".to_owned() || *args.get(1) == "--help".to_owned() {
96+
if *args.get(1) == ~"-h" || *args.get(1) == ~"--help" {
9797
let message = format!("Usage: {} [OPTIONS] [TESTNAME...]", argv0);
9898
println!("{}", getopts::usage(message, groups.as_slice()));
9999
println!("");
@@ -181,7 +181,7 @@ pub fn log_config(config: &config) {
181181
logv(c, format!("adb_test_dir: {}", config.adb_test_dir));
182182
logv(c, format!("adb_device_status: {}", config.adb_device_status));
183183
match config.test_shard {
184-
None => logv(c, "test_shard: (all)".to_owned()),
184+
None => logv(c, ~"test_shard: (all)"),
185185
Some((a,b)) => logv(c, format!("test_shard: {}.{}", a, b))
186186
}
187187
logv(c, format!("verbose: {}", config.verbose));
@@ -199,7 +199,7 @@ pub fn opt_str<'a>(maybestr: &'a Option<~str>) -> &'a str {
199199
}
200200

201201
pub fn opt_str2(maybestr: Option<~str>) -> ~str {
202-
match maybestr { None => "(none)".to_owned(), Some(s) => { s } }
202+
match maybestr { None => ~"(none)", Some(s) => { s } }
203203
}
204204

205205
pub fn str_mode(s: ~str) -> mode {
@@ -216,17 +216,17 @@ pub fn str_mode(s: ~str) -> mode {
216216

217217
pub fn mode_str(mode: mode) -> ~str {
218218
match mode {
219-
mode_compile_fail => "compile-fail".to_owned(),
220-
mode_run_fail => "run-fail".to_owned(),
221-
mode_run_pass => "run-pass".to_owned(),
222-
mode_pretty => "pretty".to_owned(),
223-
mode_debug_info => "debug-info".to_owned(),
224-
mode_codegen => "codegen".to_owned(),
219+
mode_compile_fail => ~"compile-fail",
220+
mode_run_fail => ~"run-fail",
221+
mode_run_pass => ~"run-pass",
222+
mode_pretty => ~"pretty",
223+
mode_debug_info => ~"debug-info",
224+
mode_codegen => ~"codegen",
225225
}
226226
}
227227

228228
pub fn run_tests(config: &config) {
229-
if config.target == "arm-linux-androideabi".to_owned() {
229+
if config.target == ~"arm-linux-androideabi" {
230230
match config.mode{
231231
mode_debug_info => {
232232
println!("arm-linux-androideabi debug-info \
@@ -296,10 +296,10 @@ pub fn is_test(config: &config, testfile: &Path) -> bool {
296296
// Pretty-printer does not work with .rc files yet
297297
let valid_extensions =
298298
match config.mode {
299-
mode_pretty => vec!(".rs".to_owned()),
300-
_ => vec!(".rc".to_owned(), ".rs".to_owned())
299+
mode_pretty => vec!(~".rs"),
300+
_ => vec!(~".rc", ~".rs")
301301
};
302-
let invalid_prefixes = vec!(".".to_owned(), "#".to_owned(), "~".to_owned());
302+
let invalid_prefixes = vec!(~".", ~"#", ~"~");
303303
let name = testfile.filename_str().unwrap();
304304

305305
let mut valid = false;

trunk/src/compiletest/errors.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ pub fn load_errors(testfile: &Path) -> Vec<ExpectedError> {
3131

3232
fn parse_expected(line_num: uint, line: ~str) -> Vec<ExpectedError> {
3333
let line = line.trim();
34-
let error_tag = "//~".to_owned();
34+
let error_tag = ~"//~";
3535
let mut idx;
3636
match line.find_str(error_tag) {
3737
None => return Vec::new(),

trunk/src/compiletest/header.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,10 @@ pub fn load_props(testfile: &Path) -> TestProps {
112112

113113
pub fn is_test_ignored(config: &config, testfile: &Path) -> bool {
114114
fn ignore_target(config: &config) -> ~str {
115-
"ignore-".to_owned() + util::get_os(config.target)
115+
~"ignore-" + util::get_os(config.target)
116116
}
117117
fn ignore_stage(config: &config) -> ~str {
118-
"ignore-".to_owned() + config.stage_id.split('-').next().unwrap()
118+
~"ignore-" + config.stage_id.split('-').next().unwrap()
119119
}
120120
121121
let val = iter_header(testfile, |ln| {
@@ -149,23 +149,23 @@ fn iter_header(testfile: &Path, it: |&str| -> bool) -> bool {
149149
}
150150

151151
fn parse_error_pattern(line: &str) -> Option<~str> {
152-
parse_name_value_directive(line, "error-pattern".to_owned())
152+
parse_name_value_directive(line, ~"error-pattern")
153153
}
154154

155155
fn parse_aux_build(line: &str) -> Option<~str> {
156-
parse_name_value_directive(line, "aux-build".to_owned())
156+
parse_name_value_directive(line, ~"aux-build")
157157
}
158158

159159
fn parse_compile_flags(line: &str) -> Option<~str> {
160-
parse_name_value_directive(line, "compile-flags".to_owned())
160+
parse_name_value_directive(line, ~"compile-flags")
161161
}
162162

163163
fn parse_debugger_cmd(line: &str) -> Option<~str> {
164-
parse_name_value_directive(line, "debugger".to_owned())
164+
parse_name_value_directive(line, ~"debugger")
165165
}
166166

167167
fn parse_check_line(line: &str) -> Option<~str> {
168-
parse_name_value_directive(line, "check".to_owned())
168+
parse_name_value_directive(line, ~"check")
169169
}
170170

171171
fn parse_force_host(line: &str) -> bool {
@@ -181,12 +181,12 @@ fn parse_no_prefer_dynamic(line: &str) -> bool {
181181
}
182182

183183
fn parse_exec_env(line: &str) -> Option<(~str, ~str)> {
184-
parse_name_value_directive(line, "exec-env".to_owned()).map(|nv| {
184+
parse_name_value_directive(line, ~"exec-env").map(|nv| {
185185
// nv is either FOO or FOO=BAR
186186
let mut strs: Vec<~str> = nv.splitn('=', 1).map(|s| s.to_owned()).collect();
187187

188188
match strs.len() {
189-
1u => (strs.pop().unwrap(), "".to_owned()),
189+
1u => (strs.pop().unwrap(), ~""),
190190
2u => {
191191
let end = strs.pop().unwrap();
192192
(strs.pop().unwrap(), end)
@@ -197,7 +197,7 @@ fn parse_exec_env(line: &str) -> Option<(~str, ~str)> {
197197
}
198198

199199
fn parse_pp_exact(line: &str, testfile: &Path) -> Option<Path> {
200-
match parse_name_value_directive(line, "pp-exact".to_owned()) {
200+
match parse_name_value_directive(line, ~"pp-exact") {
201201
Some(s) => Some(Path::new(s)),
202202
None => {
203203
if parse_name_directive(line, "pp-exact") {

trunk/src/compiletest/procsrv.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ fn target_env(lib_path: &str, prog: &str) -> Vec<(~str, ~str)> {
2929
(k, new_v)
3030
}).collect();
3131
if prog.ends_with("rustc.exe") {
32-
new_env.push(("RUST_THREADS".to_owned(), "1".to_owned()));
32+
new_env.push((~"RUST_THREADS", ~"1"));
3333
}
3434
return new_env;
3535
}
@@ -49,7 +49,7 @@ fn target_env(lib_path: &str, prog: &str) -> Vec<(~str,~str)> {
4949
};
5050
let prev = match env.iter().position(|&(ref k, _)| k.as_slice() == var) {
5151
Some(i) => env.remove(i).unwrap().val1(),
52-
None => "".to_owned(),
52+
None => ~"",
5353
};
5454
env.push((var.to_owned(), if prev.is_empty() {
5555
lib_path + ":" + aux_path

0 commit comments

Comments
 (0)