File tree Expand file tree Collapse file tree 4 files changed +6
-3
lines changed Expand file tree Collapse file tree 4 files changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -39,7 +39,7 @@ fn map_slices<A: copy send, B: copy send>(
39
39
log ( info, "spawning tasks" ) ;
40
40
while base < len {
41
41
let end = uint:: min ( len, base + items_per_task) ;
42
- // FIXME: why is the ::<A, ()> annotation required here?
42
+ // FIXME: why is the ::<A, ()> annotation required here? (#2617)
43
43
vec:: unpack_slice :: < A , ( ) > ( xs) { |p, _len|
44
44
let f = f ( ) ;
45
45
futures += [ future:: spawn ( ) { |copy base|
Original file line number Diff line number Diff line change @@ -9,6 +9,7 @@ import diagnostic::span_handler;
9
9
enum path_elt { path_mod( ident ) , path_name( ident ) }
10
10
type path = [ path_elt ] ;
11
11
12
+ /* FIXMEs that say "bad" are as per #2543 */
12
13
fn path_to_str_with_sep ( p : path , sep : str ) -> str {
13
14
let strs = vec:: map ( p) { |e|
14
15
alt e {
@@ -291,6 +292,7 @@ fn node_id_to_str(map: map, id: node_id) -> str {
291
292
#fmt[ "expr %s (id=%?)" ,
292
293
pprust:: expr_to_str( expr) , id]
293
294
}
295
+ // FIXMEs are as per #2410
294
296
some( node_export( _, path) ) {
295
297
#fmt[ "export %s (id=%?)" , // FIXME: add more info here
296
298
path_to_str( * path) , id]
Original file line number Diff line number Diff line change @@ -24,7 +24,7 @@ pure fn dummy_sp() -> span { ret mk_sp(0u, 0u); }
24
24
pure fn path_name ( p: @path) -> str { path_name_i ( p. idents ) }
25
25
26
26
pure fn path_name_i ( idents : [ ident ] ) -> str {
27
- // FIXME: Bad copies
27
+ // FIXME: Bad copies (#2543 -- same for everything else that says "bad")
28
28
str:: connect ( idents. map ( { |i|* i} ) , "::" )
29
29
}
30
30
Original file line number Diff line number Diff line change @@ -88,6 +88,7 @@ fn get_attr_name(attr: ast::attribute) -> ast::ident {
88
88
get_meta_item_name ( @attr. node . value )
89
89
}
90
90
91
+ // All "bad" FIXME copies are as per #2543
91
92
fn get_meta_item_name ( meta : @ast:: meta_item ) -> ast:: ident {
92
93
alt meta. node {
93
94
ast:: meta_word ( n) { /* FIXME bad */ copy n }
@@ -372,7 +373,7 @@ fn require_unique_names(diagnostic: span_handler,
372
373
for metas. each { |meta|
373
374
let name = get_meta_item_name( meta) ;
374
375
375
- // FIXME: How do I silence the warnings? --pcw
376
+ // FIXME: How do I silence the warnings? --pcw (#2619)
376
377
if map. contains_key( * name) {
377
378
diagnostic. span_fatal( meta. span,
378
379
#fmt[ "duplicate meta item `%s`" , * name] ) ;
You can’t perform that action at this time.
0 commit comments