Skip to content

Commit 686e27e

Browse files
committed
Change the blanket submodule update for library submodules to be required
These are required 100% of the time, but they are almost always required for any command that runs Cargo in the main workspace. Ideally, initializing these two standard library submodules would be lazy and only initialized when required (see #82653). However, it would require updating these in almost every Step (anything that runs `cargo` in the main workspace).
1 parent 9b0115c commit 686e27e

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

Diff for: src/bootstrap/src/lib.rs

+7-1
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,13 @@ impl Build {
441441
// Cargo.toml files.
442442
let rust_submodules = ["library/backtrace", "library/stdarch"];
443443
for s in rust_submodules {
444-
build.update_submodule(s);
444+
build.require_and_update_submodule(
445+
s,
446+
Some(
447+
"The submodule is required for the standard library \
448+
and the main Cargo workspace.",
449+
),
450+
);
445451
}
446452
// Now, update all existing submodules.
447453
build.update_existing_submodules();

0 commit comments

Comments
 (0)