Skip to content

Commit 66d2b86

Browse files
committed
---
yaml --- r: 152185 b: refs/heads/try2 c: 5527c5d h: refs/heads/master i: 152183: 175f298 v: v3
1 parent f8ee788 commit 66d2b86

File tree

5 files changed

+33
-14
lines changed

5 files changed

+33
-14
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
55
refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
8-
refs/heads/try2: b64046a5b072a34a0940785a9301669a2ea00031
8+
refs/heads/try2: 5527c5dc060754d7ca17c19886bc357ef29ec8fc
99
refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
1010
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
1111
refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/doc/guide-lifetimes.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ Now we can call `compute_distance()`:
6767
# let on_the_stack : Point = Point{x: 3.0, y: 4.0};
6868
# let on_the_heap : Box<Point> = box Point{x: 7.0, y: 9.0};
6969
# fn compute_distance(p1: &Point, p2: &Point) -> f64 { 0.0 }
70-
compute_distance(&on_the_stack, &*on_the_heap);
70+
compute_distance(&on_the_stack, on_the_heap);
7171
~~~
7272

7373
Here, the `&` operator takes the address of the variable
@@ -77,9 +77,10 @@ value. We also call this _borrowing_ the local variable
7777
`on_the_stack`, because we have created an alias: that is, another
7878
name for the same data.
7979

80-
For the second argument, we need to extract the contents of `on_the_heap`
81-
by derefercing with the `*` symbol. Now that we have the data, we need
82-
to create a reference with the `&` symbol.
80+
In the case of `on_the_heap`, however, no explicit action is necessary.
81+
The compiler will automatically convert a box box point to a reference like &point.
82+
This is another form of borrowing; in this case, the contents of the owned box
83+
are being lent out.
8384

8485
Whenever a caller lends data to a callee, there are some limitations on what
8586
the caller can do with the original. For example, if the contents of a

branches/try2/src/doc/tutorial.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,7 +1429,7 @@ contains a point, but allocated in a different location:
14291429
~~~
14301430
# struct Point { x: f64, y: f64 }
14311431
let on_the_stack : Point = Point { x: 3.0, y: 4.0 };
1432-
let owned_box : Box<Point> = box Point { x: 7.0, y: 9.0 };
1432+
let on_the_heap : Box<Point> = box Point { x: 7.0, y: 9.0 };
14331433
~~~
14341434

14351435
Suppose we want to write a procedure that computes the distance
@@ -1454,9 +1454,9 @@ Now we can call `compute_distance()` in various ways:
14541454
~~~
14551455
# struct Point{ x: f64, y: f64 };
14561456
# let on_the_stack : Point = Point { x: 3.0, y: 4.0 };
1457-
# let owned_box : Box<Point> = box Point { x: 7.0, y: 9.0 };
1457+
# let on_the_heap : Box<Point> = box Point { x: 7.0, y: 9.0 };
14581458
# fn compute_distance(p1: &Point, p2: &Point) -> f64 { 0.0 }
1459-
compute_distance(&on_the_stack, owned_box);
1459+
compute_distance(&on_the_stack, on_the_heap);
14601460
~~~
14611461

14621462
Here the `&` operator is used to take the address of the variable

branches/try2/src/librustc/middle/typeck/check/_match.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -298,9 +298,8 @@ pub fn check_pat_variant(pcx: &pat_ctxt, pat: &ast::Pat, path: &ast::Path,
298298
/// `etc` is true if the pattern said '...' and false otherwise.
299299
pub fn check_struct_pat_fields(pcx: &pat_ctxt,
300300
span: Span,
301-
path: &ast::Path,
302301
fields: &[ast::FieldPat],
303-
class_fields: Vec<ty::field_ty> ,
302+
class_fields: Vec<ty::field_ty>,
304303
class_id: ast::DefId,
305304
substitutions: &ty::substs,
306305
etc: bool) {
@@ -333,13 +332,12 @@ pub fn check_struct_pat_fields(pcx: &pat_ctxt,
333332
found_fields.insert(index);
334333
}
335334
None => {
336-
let name = pprust::path_to_str(path);
337335
// Check the pattern anyway, so that attempts to look
338336
// up its type won't fail
339337
check_pat(pcx, field.pat, ty::mk_err());
340338
tcx.sess.span_err(span,
341339
format!("struct `{}` does not have a field named `{}`",
342-
name,
340+
ty::item_path_str(tcx, class_id),
343341
token::get_ident(field.ident)).as_slice());
344342
}
345343
}
@@ -390,7 +388,7 @@ pub fn check_struct_pat(pcx: &pat_ctxt, pat_id: ast::NodeId, span: Span,
390388
}
391389
}
392390

393-
check_struct_pat_fields(pcx, span, path, fields, class_fields, struct_id,
391+
check_struct_pat_fields(pcx, span, fields, class_fields, struct_id,
394392
substitutions, etc);
395393
}
396394

@@ -413,7 +411,7 @@ pub fn check_struct_like_enum_variant_pat(pcx: &pat_ctxt,
413411
// Get the struct fields from this struct-like enum variant.
414412
let class_fields = ty::lookup_struct_fields(tcx, variant_id);
415413

416-
check_struct_pat_fields(pcx, span, path, fields, class_fields,
414+
check_struct_pat_fields(pcx, span, fields, class_fields,
417415
variant_id, substitutions, etc);
418416
}
419417
Some(&ast::DefStruct(..)) | Some(&ast::DefVariant(..)) => {
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
struct vec2 { y: f32 }
12+
struct vec3 { y: f32, z: f32 }
13+
14+
fn make(v: vec2) {
15+
let vec3 { y: _, z: _ } = v;
16+
//~^ ERROR mismatched types: expected `vec2` but found `vec3`
17+
//~^^ ERROR struct `vec2` does not have a field named `z`
18+
}
19+
20+
fn main() { }

0 commit comments

Comments
 (0)