review comments

Author: estebank

Diff for: src/test/ui/huge-array-simple-32.rs

@@ -1,11 +1,11 @@
-// ignore-32bit
+// ignore-64bit
 
 // FIXME https://github.com/rust-lang/rust/issues/59774
 // normalize-stderr-test "thread.*panicked.*Metadata module not compiled.*\n" -> ""
 // normalize-stderr-test "note:.*RUST_BACKTRACE=1.*\n" -> ""
 #![allow(exceeding_bitshifts)]
 
 fn main() {
-    let _fat: [u8; (1<<61)+(1<<31)] = //~ ERROR too big for the current architecture
-        [0; (1u64<<61) as usize +(1u64<<31) as usize];
+    let _fat: [u8; (1<<31)+(1<<15)] = //~ ERROR too big for the current architecture
+        [0; (1u32<<31) as usize +(1u32<<15) as usize];
 }

Diff for: src/test/ui/huge-array-simple-32.stderr

@@ -1,7 +1,7 @@
-error: the type `[u8; 2305843011361177600]` is too big for the current architecture
+error: the type `[u8; 2147516416]` is too big for the current architecture
   --> $DIR/huge-array-simple-32.rs:9:9
    |
-LL |     let _fat: [u8; (1<<61)+(1<<31)] =
+LL |     let _fat: [u8; (1<<31)+(1<<15)] =
    |         ^^^^
 
 error: aborting due to previous error

Diff for: src/test/ui/huge-array-simple-64.rs

@@ -1,11 +1,11 @@
-// ignore-64bit
+// ignore-32bit
 
 // FIXME https://github.com/rust-lang/rust/issues/59774
 // normalize-stderr-test "thread.*panicked.*Metadata module not compiled.*\n" -> ""
 // normalize-stderr-test "note:.*RUST_BACKTRACE=1.*\n" -> ""
 #![allow(exceeding_bitshifts)]
 
 fn main() {
-    let _fat: [u8; (1<<31)+(1<<15)] = //~ ERROR too big for the current architecture
-        [0; (1u32<<31) as usize +(1u32<<15) as usize];
+    let _fat: [u8; (1<<61)+(1<<31)] = //~ ERROR too big for the current architecture
+        [0; (1u64<<61) as usize +(1u64<<31) as usize];
 }

Diff for: src/test/ui/huge-array-simple-64.stderr

@@ -1,7 +1,7 @@
-error: the type `[u8; 2147516416]` is too big for the current architecture
+error: the type `[u8; 2305843011361177600]` is too big for the current architecture
   --> $DIR/huge-array-simple-64.rs:9:9
    |
-LL |     let _fat: [u8; (1<<31)+(1<<15)] =
+LL |     let _fat: [u8; (1<<61)+(1<<31)] =
    |         ^^^^
 
 error: aborting due to previous error

Diff for: src/test/ui/issues/issue-15919-32.rs

@@ -7,3 +7,6 @@
 fn main() {
     let x = [0usize; 0xffff_ffff]; //~ ERROR too big
 }
+
+// These two tests need to have different literals, as we can't rely on conditional compilation
+// for them while retaining the same spans/lines.

Diff for: src/test/ui/issues/issue-15919-64.rs

@@ -7,3 +7,6 @@
 fn main() {
     let x = [0usize; 0xffff_ffff_ffff_ffff]; //~ ERROR too big
 }
+
+// These two tests need to have different literals, as we can't rely on conditional compilation
+// for them while retaining the same spans/lines.