Skip to content

Commit 619dcc0

Browse files
committed
Fix target_os for mipsel-sony-psx
Previously set to `target_os = "none"` and `target_env = "psx"`, but although the Playstation 1 is _close_ to a bare metal target in some regards, it's still very much an operating system, so we should set `target_os = "psx"`. This also matches the `mipsel-sony-psp` target, which sets `target_os = "psp"`.
1 parent 612796c commit 619dcc0

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

compiler/rustc_target/src/spec/targets/mipsel_sony_psx.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ pub(crate) fn target() -> Target {
1414
arch: "mips".into(),
1515

1616
options: TargetOptions {
17-
os: "none".into(),
18-
env: "psx".into(),
17+
os: "psx".into(),
1918
vendor: "sony".into(),
2019
linker_flavor: LinkerFlavor::Gnu(Cc::No, Lld::Yes),
2120
cpu: "mips1".into(),

tests/ui/check-cfg/well-known-values.stderr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ warning: unexpected `cfg` condition value: `_UNEXPECTED_VALUE`
156156
LL | target_env = "_UNEXPECTED_VALUE",
157157
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
158158
|
159-
= note: expected values for `target_env` are: ``, `gnu`, `msvc`, `musl`, `newlib`, `nto70`, `nto71`, `ohos`, `p1`, `p2`, `psx`, `relibc`, `sgx`, and `uclibc`
159+
= note: expected values for `target_env` are: ``, `gnu`, `msvc`, `musl`, `newlib`, `nto70`, `nto71`, `ohos`, `p1`, `p2`, `relibc`, `sgx`, and `uclibc`
160160
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg.html> for more information about checking conditional configuration
161161

162162
warning: unexpected `cfg` condition value: `_UNEXPECTED_VALUE`

0 commit comments

Comments
 (0)