Skip to content

Commit 5e6ae8b

Browse files
committed
More PR feedback
1 parent 61150a8 commit 5e6ae8b

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

Diff for: library/core/src/intrinsics/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3247,7 +3247,7 @@ pub const fn three_way_compare<T: Copy>(_lhs: T, _rhss: T) -> crate::cmp::Orderi
32473247
/// Combine two values which have no bits in common.
32483248
///
32493249
/// This allows the backend to implement it as `a + b` *or* `a | b`,
3250-
/// depending which us easier to implement on a specific target.
3250+
/// depending which is easier to implement on a specific target.
32513251
///
32523252
/// # Safety
32533253
///

Diff for: library/core/src/num/uint_macros.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -1187,13 +1187,11 @@ macro_rules! uint_impl {
11871187
self % rhs
11881188
}
11891189

1190-
/// Same value as
1191-
#[doc = concat!("`<", stringify!($SelfT), " as BitOr>::bitor(self, other)`")]
1192-
/// but UB if any bit position is set in both inputs.
1190+
/// Same value as `self | other`, but UB if any bit position is set in both inputs.
11931191
///
1194-
/// This is a situational μoptimization for places where you'd rather use
1195-
/// addition on some platforms and bitwise or on other platforms, based on
1196-
/// exactly which instructions combine better with whatever else you're
1192+
/// This is a situational micro-optimization for places where you'd rather
1193+
/// use addition on some platforms and bitwise or on other platforms, based
1194+
/// on exactly which instructions combine better with whatever else you're
11971195
/// doing. Note that there's no reason to bother using this for places
11981196
/// where it's clear from the operations involved that they can't overlap.
11991197
/// For example, if you're combining `u16`s into a `u32` with

0 commit comments

Comments
 (0)