Showcase a broken diagnostic

oli-obk · oli-obk · commit 5ace12c409ef · 2022-09-23T07:10:11.000Z
diff --git a/src/test/ui/impl-trait/unactionable_diagnostic.rs b/src/test/ui/impl-trait/unactionable_diagnostic.rs
@@ -4,10 +4,10 @@ struct Foo;
 
 impl Trait for Foo {}
 
-fn foo<'t, P>(
+fn foo<'x, P>(
     post: P,
-    x: &'t Foo,
-) -> &'t impl Trait {
+    x: &'x Foo,
+) -> &'x impl Trait {
     //~^ HELP: consider adding an explicit lifetime bound...
     x
 }
diff --git a/src/test/ui/impl-trait/unactionable_diagnostic.stderr b/src/test/ui/impl-trait/unactionable_diagnostic.stderr
@@ -6,7 +6,7 @@ LL |     foo(post, x)
    |
 help: consider adding an explicit lifetime bound...
    |
-LL | ) -> &'t impl Trait + 't {
+LL | ) -> &'x impl Trait + 't {
    |                     ++++
 
 error: aborting due to previous error

Original file line number	Diff line number	Diff line change
`@@ -4,10 +4,10 @@ struct Foo;`
`4`	`4`
`5`	`5`	`impl Trait for Foo {}`
`6`	`6`
`7`		`-fn foo<'t, P>(`
	`7`	`+fn foo<'x, P>(`
`8`	`8`	`post: P,`
`9`		`- x: &'t Foo,`
`10`		`-) -> &'t impl Trait {`
	`9`	`+ x: &'x Foo,`
	`10`	`+) -> &'x impl Trait {`
`11`	`11`	`//~^ HELP: consider adding an explicit lifetime bound...`
`12`	`12`	`x`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ LL \| foo(post, x)`
`6`	`6`	`\|`
`7`	`7`	`help: consider adding an explicit lifetime bound...`
`8`	`8`	`\|`
`9`		`-LL \| ) -> &'t impl Trait + 't {`
	`9`	`+LL \| ) -> &'x impl Trait + 't {`
`10`	`10`	`\| ++++`
`11`	`11`
`12`	`12`	`error: aborting due to previous error`