---

yaml
---
r: 93156
b: refs/heads/try
c: ad46544
h: refs/heads/master
v: v3

Author: reedlepee123

[refs]

@@ -2,7 +2,7 @@
 refs/heads/master: 0da105a8b7b6b1e0568e8ff20f6ff4b13cc7ecc2
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: a6d3e57dca68fde4effdda3e4ae2887aa535fcd6
-refs/heads/try: 0ada7c7ffe453b9df849996f8dca0b8d0f2d9e62
+refs/heads/try: ad465441ba3424cc5bcba2227c6a42ffe09fd77f
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
 refs/heads/try2: 147ecfdd8221e4a4d4e090486829a06da1e0ca3c

branches/try/src/libextra/arc.rs

@@ -50,7 +50,6 @@ use std::borrow;
 
 /// As sync::condvar, a mechanism for unlock-and-descheduling and signaling.
 pub struct Condvar<'self> {
-    // all were already priv
     priv is_mutex: bool,
     priv failed: &'self mut bool,
     priv cond: &'self sync::Condvar<'self>
@@ -109,7 +108,6 @@ impl<'self> Condvar<'self> {
  ****************************************************************************/
 
 /// An atomically reference counted wrapper for shared immutable state.
-// all were already priv
 pub struct Arc<T> { priv x: UnsafeArc<T> }
 
 
@@ -164,7 +162,6 @@ struct MutexArcInner<T> { priv lock: Mutex, priv failed: bool, priv data: T }
 
 /// An Arc with mutable data protected by a blocking mutex.
 #[no_freeze]
-//All were already priv
 pub struct MutexArc<T> { priv x: UnsafeArc<MutexArcInner<T>> }
 
 
@@ -347,7 +344,6 @@ struct RWArcInner<T> { priv lock: RWLock, priv failed: bool, priv data: T }
  */
 #[no_freeze]
 pub struct RWArc<T> {
-    // all were already priv
     priv x: UnsafeArc<RWArcInner<T>>,
 }
 
@@ -526,15 +522,13 @@ fn borrow_rwlock<T:Freeze + Send>(state: *mut RWArcInner<T>) -> *RWLock {
 /// The "write permission" token used for RWArc.write_downgrade().
 pub struct RWWriteMode<'self, T> {
 
-/// reedlepee added priv in all the feilds below
     priv data: &'self mut T,
     priv token: sync::RWLockWriteMode<'self>,
     priv poison: PoisonOnFail,
 }
 
 /// The "read permission" token used for RWArc.write_downgrade().
 pub struct RWReadMode<'self, T> {
-/// reedlepee added priv in all the feilds below
     priv data: &'self T,
     priv token: sync::RWLockReadMode<'self>,
 }

branches/try/src/libextra/arena.rs

@@ -62,7 +62,6 @@ pub struct Arena {
     // The head is separated out from the list as a unbenchmarked
     // microoptimization, to avoid needing to case on the list to
     // access the head.
-/// no change  by reedlepee all were already priv
     priv head: Chunk,
     priv pod_head: Chunk,
     priv chunks: @mut MutList<Chunk>,

branches/try/src/libextra/base64.rs

@@ -21,7 +21,6 @@ pub enum CharacterSet {
 
 /// Contains configuration parameters for `to_base64`.
 pub struct Config {
-    /// all were made priv by reedlepee
     /// Character set to use
     priv char_set: CharacterSet,
     /// True to pad output with `=` characters

branches/try/src/libextra/bitv.rs

@@ -225,7 +225,6 @@ enum Op {Union, Intersect, Assign, Difference}
 /// The bitvector type
 #[deriving(Clone)]
 pub struct Bitv {
-    /// all were made priv by reedlepee
     /// Internal representation of the bit vector (small or large)
     priv rep: BitvVariant,
     /// The number of valid bits in the internal representation
@@ -574,7 +573,6 @@ fn iterate_bits(base: uint, bits: uint, f: &fn(uint) -> bool) -> bool {
 
 /// An iterator for `Bitv`.
 pub struct BitvIterator<'self> {
-    /// all were already priv
     priv bitv: &'self Bitv,
     priv next_idx: uint,
     priv end_idx: uint,
@@ -636,7 +634,6 @@ impl<'self> RandomAccessIterator<bool> for BitvIterator<'self> {
 /// as a `uint`.
 #[deriving(Clone)]
 pub struct BitvSet {
-    // all were already priv!!
     priv size: uint,
 
     // In theory this is a `Bitv` instead of always a `BigBitv`, but knowing that
@@ -903,7 +900,6 @@ impl BitvSet {
 }
 
 pub struct BitvSetIterator<'self> {
-    // all were already priv
     priv set: &'self BitvSet,
     priv next_idx: uint
 }

branches/try/src/libextra/c_vec.rs

@@ -44,7 +44,6 @@ use std::util;
  * The type representing a foreign chunk of memory
  */
 pub struct CVec<T> {
-    /// No change all were allready priv!!
     priv base: *mut T,
     priv len: uint,
     priv rsrc: @DtorRes,

branches/try/src/libextra/comm.rs

@@ -23,7 +23,6 @@ use std::comm;
 
 /// An extension of `pipes::stream` that allows both sending and receiving.
 pub struct DuplexStream<T, U> {
-// all were already priv
     priv chan: Chan<T>,
     priv port: Port<U>,
 }
@@ -95,7 +94,6 @@ pub fn DuplexStream<T:Send,U:Send>()
 // all were already priv
 pub struct SyncChan<T> { priv duplex_stream: DuplexStream<T, ()> }
 /// An extension of `pipes::stream` that acknowledges each message received.
-// all were already priv
 pub struct SyncPort<T> { priv duplex_stream: DuplexStream<(), T> }
 
 impl<T: Send> GenericChan<T> for SyncChan<T> {

branches/try/src/libextra/crypto/cryptoutil.rs

@@ -284,7 +284,6 @@ macro_rules! impl_fixed_buffer( ($name:ident, $size:expr) => (
 
 /// A fixed size buffer of 64 bytes useful for cryptographic operations.
 pub struct FixedBuffer64 {
-    // already priv
     priv buffer: [u8, ..64],
     priv buffer_idx: uint,
 }
@@ -303,7 +302,6 @@ impl_fixed_buffer!(FixedBuffer64, 64)
 
 /// A fixed size buffer of 128 bytes useful for cryptographic operations.
 pub struct FixedBuffer128 {
-    // already priv
     priv buffer: [u8, ..128],
     priv buffer_idx: uint,
 }

branches/try/src/libextra/crypto/md5.rs

@@ -159,7 +159,6 @@ static C4: [u32, ..16] = [
 
 /// The MD5 Digest algorithm
 pub struct Md5 {
-    // already priv
     priv length_bytes: u64,
     priv buffer: FixedBuffer64,
     priv state: Md5State,

branches/try/src/libextra/crypto/sha1.rs

@@ -43,7 +43,6 @@ static K3: u32 = 0xCA62C1D6u32;
 
 /// Structure representing the state of a Sha1 computation
 pub struct Sha1 {
-    // already priv
     priv h: [u32, ..DIGEST_BUF_LEN],
     priv length_bits: u64,
     priv buffer: FixedBuffer64,

branches/try/src/libextra/crypto/sha2.rs

@@ -234,7 +234,6 @@ impl Engine512 {
 
 /// The SHA-512 hash algorithm
 pub struct Sha512 {
-    // already priv
     priv engine: Engine512
 }
 
@@ -288,7 +287,6 @@ static H512: [u64, ..8] = [
 
 /// The SHA-384 hash algorithm
 pub struct Sha384 {
-    // already priv
     priv engine: Engine512
 }
 
@@ -340,7 +338,6 @@ static H384: [u64, ..8] = [
 
 /// The SHA-512 hash algorithm with digest truncated to 256 bits
 pub struct Sha512Trunc256 {
-    // already priv
     priv engine: Engine512
 }
 
@@ -390,7 +387,6 @@ static H512_TRUNC_256: [u64, ..8] = [
 
 /// The SHA-512 hash algorithm with digest truncated to 224 bits
 pub struct Sha512Trunc224 {
-    // already priv
     priv engine: Engine512
 }
 
@@ -647,7 +643,6 @@ impl Engine256 {
 
 /// The SHA-256 hash algorithm
 pub struct Sha256 {
-    // already priv
     priv engine: Engine256
 }
 
@@ -701,7 +696,6 @@ static H256: [u32, ..8] = [
 
 /// The SHA-224 hash algorithm
 pub struct Sha224 {
-    // already priv
     priv engine: Engine256
 }
 

branches/try/src/libextra/dlist.rs

@@ -32,7 +32,6 @@ use container::Deque;
 
 /// A doubly-linked list.
 pub struct DList<T> {
-    // all were already priv
     priv length: uint,
     priv list_head: Link<T>,
     priv list_tail: Rawlink<Node<T>>,
@@ -50,15 +49,13 @@ struct Node<T> {
 /// Double-ended DList iterator
 #[deriving(Clone)]
 pub struct DListIterator<'self, T> {
-    // all were already priv
     priv head: &'self Link<T>,
     priv tail: Rawlink<Node<T>>,
     priv nelem: uint,
 }
 
 /// Double-ended mutable DList iterator
 pub struct MutDListIterator<'self, T> {
-    // all were already priv
     priv list: &'self mut DList<T>,
     priv head: Rawlink<Node<T>>,
     priv tail: Rawlink<Node<T>>,
@@ -68,7 +65,6 @@ pub struct MutDListIterator<'self, T> {
 /// DList consuming iterator
 #[deriving(Clone)]
 pub struct MoveIterator<T> {
-    // all were already priv
     priv list: DList<T>
 }
 

branches/try/src/libextra/ebml.rs

@@ -30,7 +30,6 @@ struct EbmlState {
 
 #[deriving(Clone)]
 pub struct Doc {
-    // all these should be public
     data: @~[u8],
     start: uint,
     end: uint,
@@ -51,9 +50,7 @@ impl Doc {
 }
 
 pub struct TaggedDoc {
-    // was made privv by reedlepee
     priv tag: uint,
-    // should be public
     doc: Doc,
 }
 
@@ -287,7 +284,6 @@ pub mod reader {
     pub fn doc_as_i64(d: Doc) -> i64 { doc_as_u64(d) as i64 }
 
     pub struct Decoder {
-        // all were already  priv
         priv parent: Doc,
         priv pos: uint,
     }
@@ -622,9 +618,7 @@ pub mod writer {
 
     // ebml writing
     pub struct Encoder {
-    /// should be public!!
     writer: @io::Writer,
-    /// this was already privv!!
     priv size_positions: ~[uint],
     }
 

branches/try/src/libextra/enum_set.rs

@@ -18,7 +18,6 @@
 pub struct EnumSet<E> {
     // We must maintain the invariant that no bits are set
     // for which no variant exists
-    // all were already priv
     priv bits: uint
 }
 
@@ -101,7 +100,6 @@ impl<E:CLike> BitAnd<EnumSet<E>, EnumSet<E>> for EnumSet<E> {
 
 /// An iterator over an EnumSet
 pub struct EnumSetIterator<E> {
-    // all were already priv
     priv index: uint,
     priv bits: uint,
 }

branches/try/src/libextra/fileinput.rs

@@ -109,7 +109,6 @@ file is `stdin`.
 */
 #[deriving(Clone)]
 pub struct FileInputState {
-    // all were priv made by reedlepee
     priv current_path: Option<Path>,
     priv line_num: uint,
     priv line_num_file: uint
@@ -156,7 +155,6 @@ struct FileInput_ {
 // "self.fi" -> "self." and renaming FileInput_. Documentation above
 // will likely have to be updated to use `let mut in = ...`.
 pub struct FileInput  {
-/// all were made priv by reedlepee
     priv fi: @mut FileInput_
 }
 

branches/try/src/libextra/future.rs

@@ -32,7 +32,6 @@ use std::util::replace;
 
 /// A type encapsulating the result of a computation which may not be complete
 pub struct Future<A> {
-    // all were already privv!!
     priv state: FutureState<A>,
 }
 

branches/try/src/libextra/getopts.rs

@@ -112,8 +112,6 @@ pub enum Occur {
 /// A description of a possible option.
 #[deriving(Clone, Eq)]
 pub struct Opt {
-
-    /// reedlepee added priv infront of them!!
     /// Name of the option
     name: Name,
     /// Wheter it has an argument...  should be public!!
@@ -136,7 +134,6 @@ enum Optval {
 #[deriving(Clone, Eq)]
 pub struct Matches {
 
-/// reedlepee added priv infront of all
     /// Options that matched
     priv opts: ~[Opt],
     /// Values of the Options that matched

branches/try/src/libextra/glob.rs

@@ -33,7 +33,6 @@ use sort;
  * pattern - see the `glob` function for more details.
  */
 pub struct GlobIterator {
-    /// no change by reedlepee all were priv already!!
     priv root: Path,
     priv dir_patterns: ~[Pattern],
     priv options: MatchOptions,
@@ -157,7 +156,6 @@ fn list_dir_sorted(path: &Path) -> ~[Path] {
  */
 #[deriving(Clone, Eq, TotalEq, Ord, TotalOrd, IterBytes, Default)]
 pub struct Pattern {
-    // already priv
     priv tokens: ~[PatternToken]
 }
 
@@ -476,7 +474,6 @@ fn chars_eq(a: char, b: char, case_sensitive: bool) -> bool {
  */
 #[deriving(Clone, Eq, TotalEq, Ord, TotalOrd, IterBytes, Default)]
 pub struct MatchOptions {
-/// all were made priv  by reedlepee
 
     /**
      * Whether or not patterns should be matched in a case-sensitive manner. This

branches/try/src/libextra/io_util.rs

@@ -16,7 +16,6 @@ use std::cast;
 
 /// An implementation of the io::Reader interface which reads a buffer of bytes
 pub struct BufReader {
-    // all were made priv by reedlepee
     /// The buffer of bytes to read
     priv buf: ~[u8],
     /// The current position in the buffer of bytes