Skip to content

Commit 4840064

Browse files
committed
Removed module macro workaround for signed and unsigned integers
1 parent 0d8ace8 commit 4840064

File tree

12 files changed

+93
-57
lines changed

12 files changed

+93
-57
lines changed

src/libstd/num/i16.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,18 @@
1010

1111
//! Operations and constants for `i16`
1212
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
1318
use num::{BitCount, CheckedAdd, CheckedSub, CheckedMul};
19+
use num::{CheckedDiv, Zero, One, strconv};
20+
use num::{ToStrRadix, FromStrRadix};
1421
use option::{Option, Some, None};
22+
use str;
1523
use unstable::intrinsics;
1624

17-
pub use self::generated::*;
18-
1925
int_module!(i16, 16)
2026

2127
impl BitCount for i16 {

src/libstd/num/i32.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,18 @@
1010

1111
//! Operations and constants for `i32`
1212
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
1318
use num::{BitCount, CheckedAdd, CheckedSub, CheckedMul};
19+
use num::{CheckedDiv, Zero, One, strconv};
20+
use num::{ToStrRadix, FromStrRadix};
1421
use option::{Option, Some, None};
22+
use str;
1523
use unstable::intrinsics;
1624

17-
pub use self::generated::*;
18-
1925
int_module!(i32, 32)
2026

2127
impl BitCount for i32 {

src/libstd/num/i64.rs

+9-3
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,20 @@
1010

1111
//! Operations and constants for `i64`
1212
13-
use num::{BitCount, CheckedAdd, CheckedSub};
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
1418
#[cfg(target_word_size = "64")]
1519
use num::CheckedMul;
20+
use num::{BitCount, CheckedAdd, CheckedSub};
21+
use num::{CheckedDiv, Zero, One, strconv};
22+
use num::{ToStrRadix, FromStrRadix};
1623
use option::{Option, Some, None};
24+
use str;
1725
use unstable::intrinsics;
1826

19-
pub use self::generated::*;
20-
2127
int_module!(i64, 64)
2228

2329
impl BitCount for i64 {

src/libstd/num/i8.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,18 @@
1010

1111
//! Operations and constants for `i8`
1212
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
1318
use num::{BitCount, CheckedAdd, CheckedSub, CheckedMul};
19+
use num::{CheckedDiv, Zero, One, strconv};
20+
use num::{ToStrRadix, FromStrRadix};
1421
use option::{Option, Some, None};
22+
use str;
1523
use unstable::intrinsics;
1624

17-
pub use self::generated::*;
18-
1925
int_module!(i8, 8)
2026

2127
impl BitCount for i8 {

src/libstd/num/int.rs

+8-6
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,18 @@
1212
1313
#[allow(non_uppercase_statics)];
1414

15+
use prelude::*;
16+
17+
use default::Default;
1518
use num::{BitCount, CheckedAdd, CheckedSub, CheckedMul};
19+
use num::{CheckedDiv, Zero, One, strconv};
20+
use num::{ToStrRadix, FromStrRadix};
1621
use option::{Option, Some, None};
22+
use str;
1723
use unstable::intrinsics;
1824

19-
pub use self::generated::*;
20-
21-
#[cfg(target_word_size = "32")] pub static bits: uint = 32;
22-
#[cfg(target_word_size = "64")] pub static bits: uint = 64;
23-
24-
int_module!(int, super::bits)
25+
#[cfg(target_word_size = "32")] int_module!(int, 32)
26+
#[cfg(target_word_size = "64")] int_module!(int, 64)
2527

2628
#[cfg(target_word_size = "32")]
2729
impl BitCount for int {

src/libstd/num/int_macros.rs

+2-14
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,10 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// FIXME(#4375): This shouldn't have to be a nested module named 'generated'...
12-
// FIXME(#10716): ... but now that we could solve that, the import lines and
13-
// attributes still prevent a removal of that module.
14-
1511
#[macro_escape];
1612
#[doc(hidden)];
1713

18-
macro_rules! int_module (($T:ty, $bits:expr) => (mod generated {
19-
20-
#[allow(non_uppercase_statics)];
21-
22-
use default::Default;
23-
use num::{ToStrRadix, FromStrRadix};
24-
use num::{CheckedDiv, Zero, One, strconv};
25-
use prelude::*;
26-
use str;
14+
macro_rules! int_module (($T:ty, $bits:expr) => (
2715

2816
pub static bits : uint = $bits;
2917
pub static bytes : uint = ($bits / 8);
@@ -781,4 +769,4 @@ mod tests {
781769
}
782770
}
783771

784-
}))
772+
))

src/libstd/num/u16.rs

+9-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,19 @@
1010

1111
//! Operations and constants for `u16`
1212
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
18+
use num::BitCount;
1319
use num::{CheckedAdd, CheckedSub, CheckedMul};
20+
use num::{CheckedDiv, Zero, One, strconv};
21+
use num::{ToStrRadix, FromStrRadix};
1422
use option::{Option, Some, None};
23+
use str;
1524
use unstable::intrinsics;
1625

17-
pub use self::generated::*;
18-
1926
uint_module!(u16, i16, 16)
2027

2128
impl CheckedAdd for u16 {

src/libstd/num/u32.rs

+9-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,19 @@
1010

1111
//! Operations and constants for `u32`
1212
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
18+
use num::BitCount;
1319
use num::{CheckedAdd, CheckedSub, CheckedMul};
20+
use num::{CheckedDiv, Zero, One, strconv};
21+
use num::{ToStrRadix, FromStrRadix};
1422
use option::{Option, Some, None};
23+
use str;
1524
use unstable::intrinsics;
1625

17-
pub use self::generated::*;
18-
1926
uint_module!(u32, i32, 32)
2027

2128
impl CheckedAdd for u32 {

src/libstd/num/u64.rs

+10-3
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,21 @@
1010

1111
//! Operations and constants for `u64`
1212
13-
use num::{CheckedAdd, CheckedSub};
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
18+
use num::BitCount;
1419
#[cfg(target_word_size = "64")]
1520
use num::CheckedMul;
21+
use num::{CheckedAdd, CheckedSub};
22+
use num::{CheckedDiv, Zero, One, strconv};
23+
use num::{ToStrRadix, FromStrRadix};
1624
use option::{Option, Some, None};
25+
use str;
1726
use unstable::intrinsics;
1827

19-
pub use self::generated::*;
20-
2128
uint_module!(u64, i64, 64)
2229

2330
impl CheckedAdd for u64 {

src/libstd/num/u8.rs

+9-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,19 @@
1010

1111
//! Operations and constants for `u8`
1212
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
18+
use num::BitCount;
1319
use num::{CheckedAdd, CheckedSub, CheckedMul};
20+
use num::{CheckedDiv, Zero, One, strconv};
21+
use num::{ToStrRadix, FromStrRadix};
1422
use option::{Option, Some, None};
23+
use str;
1524
use unstable::intrinsics;
1625

17-
pub use self::generated::*;
18-
1926
uint_module!(u8, i8, 8)
2027

2128
impl CheckedAdd for u8 {

src/libstd/num/uint.rs

+11-4
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,20 @@
1010

1111
//! Operations and constants for `uint`
1212
13-
use num;
13+
#[allow(non_uppercase_statics)];
14+
15+
use prelude::*;
16+
17+
use default::Default;
18+
use mem;
19+
use num::BitCount;
1420
use num::{CheckedAdd, CheckedSub, CheckedMul};
21+
use num::{CheckedDiv, Zero, One, strconv};
22+
use num::{ToStrRadix, FromStrRadix};
23+
use num;
1524
use option::{Option, Some, None};
25+
use str;
1626
use unstable::intrinsics;
17-
use mem;
18-
19-
pub use self::generated::*;
2027

2128
uint_module!(uint, int, ::int::bits)
2229

src/libstd/num/uint_macros.rs

+2-15
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,10 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11-
// FIXME(#4375): This shouldn't have to be a nested module named 'generated'...
12-
// FIXME(#10716): ... but now that we could solve that, the import lines and
13-
// attributes still prevent a removal of that module.
14-
1511
#[macro_escape];
1612
#[doc(hidden)];
1713

18-
macro_rules! uint_module (($T:ty, $T_SIGNED:ty, $bits:expr) => (mod generated {
19-
20-
#[allow(non_uppercase_statics)];
21-
22-
use default::Default;
23-
use num::BitCount;
24-
use num::{ToStrRadix, FromStrRadix};
25-
use num::{CheckedDiv, Zero, One, strconv};
26-
use prelude::*;
27-
use str;
14+
macro_rules! uint_module (($T:ty, $T_SIGNED:ty, $bits:expr) => (
2815

2916
pub static bits : uint = $bits;
3017
pub static bytes : uint = ($bits / 8);
@@ -554,4 +541,4 @@ mod tests {
554541
}
555542
}
556543

557-
}))
544+
))

0 commit comments

Comments
 (0)