Skip to content

Commit 458a57a

Browse files
authored
Rollup merge of #130256 - Zalathar:dump-stamp, r=jieyouxu
Re-run coverage tests if `coverage-dump` was modified If the `coverage-dump` tool was modified, coverage tests should not be treated as up-to-date, because the tool's output might have changed. Bootstrap already handles rebuilding the tool itself if its sources were changed, so all compiletest needs to do here is include the binary in the list of files whose timestamps are checked. This should have no effect on non-coverage tests, because bootstrap won't pass the `--coverage-dump-path` flag, so the path in compiletest's config will be None.
2 parents a3d9d13 + ed9b2ba commit 458a57a

File tree

1 file changed

+6
-0
lines changed
  • src/tools/compiletest/src

1 file changed

+6
-0
lines changed

Diff for: src/tools/compiletest/src/lib.rs

+6
Original file line numberDiff line numberDiff line change
@@ -647,6 +647,12 @@ fn common_inputs_stamp(config: &Config) -> Stamp {
647647
stamp.add_path(&rust_src_dir.join("src/etc/htmldocck.py"));
648648
}
649649

650+
// Re-run coverage tests if the `coverage-dump` tool was modified,
651+
// because its output format might have changed.
652+
if let Some(coverage_dump_path) = &config.coverage_dump_path {
653+
stamp.add_path(coverage_dump_path)
654+
}
655+
650656
stamp.add_dir(&rust_src_dir.join("src/tools/run-make-support"));
651657

652658
// Compiletest itself.

0 commit comments

Comments
 (0)