rewrite extern-multiple-copies2 to rmake

Author: Oneirical

Diff for: src/tools/tidy/src/allowed_run_make_makefiles.txt

@@ -17,7 +17,6 @@ run-make/emit-to-stdout/Makefile
 run-make/export-executable-symbols/Makefile
 run-make/extern-flag-disambiguates/Makefile
 run-make/extern-fn-reachable/Makefile
-run-make/extern-multiple-copies2/Makefile
 run-make/fmt-write-bloat/Makefile
 run-make/foreign-double-unwind/Makefile
 run-make/foreign-exceptions/Makefile

Diff for: tests/run-make/extern-diff-internal-name/rmake.rs

@@ -7,8 +7,6 @@
 // make a resurgence.
 // See https://github.com/rust-lang/rust/pull/17189
 
-//FIXME(Oneirical): test-various
-
 use run_make_support::{rust_lib_name, rustc};
 
 fn main() {

Diff for: tests/run-make/extern-multiple-copies/rmake.rs

@@ -4,8 +4,6 @@
 // in successful compilation.
 // https://github.com/rust-lang/rust/pull/29961
 
-// FIXME(Oneirical): test-various
-
 use run_make_support::{path, rfs, rust_lib_name, rustc};
 
 fn main() {

Diff for: tests/run-make/extern-multiple-copies2/Makefile

@@ -0,0 +1,22 @@
+// Almost identical to `extern-multiple-copies`, but with a variation in the --extern calls
+// and the addition of #[macro_use] in the rust code files, which used to break --extern
+// until #33625.
+// In this test, the rust library foo1 exists in two different locations, but only one
+// is required by the --extern flag. This test checks that the copy is ignored (as --extern
+// demands fetching only the original instance of foo1) and that no error is emitted, resulting
+// in successful compilation.
+// https://github.com/rust-lang/rust/issues/33762
+
+use run_make_support::{path, rfs, rust_lib_name, rustc};
+
+fn main() {
+    rustc().input("foo1.rs").run();
+    rustc().input("foo2.rs").run();
+    rfs::create_dir("foo");
+    rfs::copy(rust_lib_name("foo1"), path("foo").join(rust_lib_name("foo1")));
+    rustc()
+        .input("bar.rs")
+        .extern_("foo1", path("foo").join(rust_lib_name("foo1")))
+        .extern_("foo2", rust_lib_name("foo2"))
+        .run();
+}