add retry support to recursive_remove

Author: Shourya742

src/build_helper/src/fs/mod.rs

@@ -31,25 +31,47 @@ where
 ///
 /// FIXME: this implementation is insufficiently robust to replace bootstrap's clean `rm_rf`
 /// implementation:
-///
-/// - This implementation currently does not perform retries.
 #[track_caller]
 pub fn recursive_remove<P: AsRef<Path>>(path: P) -> io::Result<()> {
     let path = path.as_ref();
-    let metadata = fs::symlink_metadata(path)?;
-    #[cfg(windows)]
-    let is_dir_like = |meta: &fs::Metadata| {
-        use std::os::windows::fs::FileTypeExt;
-        meta.is_dir() || meta.file_type().is_symlink_dir()
-    };
-    #[cfg(not(windows))]
-    let is_dir_like = fs::Metadata::is_dir;
 
-    if is_dir_like(&metadata) {
-        fs::remove_dir_all(path)
-    } else {
-        try_remove_op_set_perms(fs::remove_file, path, metadata)
+    for retry in 0..5 {
+        match fs::symlink_metadata(path) {
+            Ok(metadata) => {
+                #[cfg(windows)]
+                let is_dir_like = |meta: &fs::Metadata| {
+                    use std::os::windows::fs::FileTypeExt;
+                    meta.is_dir() || meta.file_type().is_symlink_dir()
+                };
+                #[cfg(not(windows))]
+                let is_dir_like = fs::Metadata::is_dir;
+
+                let result = if is_dir_like(&metadata) {
+                    fs::remove_dir_all(path)
+                } else {
+                    try_remove_op_set_perms(fs::remove_file, path, metadata)
+                };
+
+                match result {
+                    Ok(()) => return Ok(()),
+                    Err(_) if retry < 4 => {
+                        continue;
+                    }
+                    Err(e) => return Err(e),
+                }
+            }
+
+            Err(e) if e.kind() == io::ErrorKind::NotFound => return Ok(()),
+
+            Err(_) if retry < 4 => {
+                continue;
+            }
+
+            Err(e) => return Err(e),
+        }
     }
+
+    Ok(())
 }
 
 fn try_remove_op_set_perms<'p, Op>(mut op: Op, path: &'p Path, metadata: Metadata) -> io::Result<()>