Rollup merge of #120765 - nnethercote:reorder-diag-API, r=compiler-errors

Reorder diagnostics API

The totally random ordering of diagnostic methods in `DiagCtxt` has been low-key driving me crazy for a while now.

r? ``@compiler-errors``

Author: matthiaskrgr