Skip to content

Commit 30a0709

Browse files
Add comment explaining why the ENABLE_GCC_CODEGEN env variable is needed
1 parent 2dbe7d8 commit 30a0709

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Diff for: src/ci/docker/host-x86_64/x86_64-gnu-llvm-15/script.sh

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ set -ex
44

55
# Only run the stage 1 tests on merges, not on PR CI jobs.
66
if [[ -z "${PR_CI_JOB}" ]]; then
7+
# When running gcc backend tests, we need to install `libgccjit` and to not run llvm codegen
8+
# tests as it will fail them.
79
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
810
../x.py --stage 1 test --skip src/tools/tidy --skip tests/codegen
911
else
@@ -23,6 +25,8 @@ if [[ -z "${PR_CI_JOB}" ]]; then
2325
../x.py --stage 1 test tests/ui-fulldeps
2426
fi
2527

28+
# When running gcc backend tests, we need to install `libgccjit` and to not run llvm codegen
29+
# tests as it will fail them.
2630
# NOTE: intentionally uses all of `x.py`, `x`, and `x.ps1` to make sure they all work on Linux.
2731
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
2832
../x.py --stage 2 test --skip src/tools/tidy --skip tests/codegen

Diff for: src/ci/run.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,13 @@ else
126126

127127
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir"
128128

129+
# When running gcc backend tests, we need to install `libgccjit` and to not run llvm codegen
130+
# tests as it will fail them.
129131
if [[ "${ENABLE_GCC_CODEGEN}" == "1" ]]; then
130-
# Test the Cranelift backend in CI. Bootstrap knows which targets to run tests on.
132+
# Test the Cranelift and GCC backends in CI. Bootstrap knows which targets to run tests on.
131133
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift,gcc"
132134
else
133-
# Test the Cranelift and GCC backends in CI. Bootstrap knows which targets to run tests on.
135+
# Test the Cranelift backend in CI. Bootstrap knows which targets to run tests on.
134136
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-backends=llvm,cranelift"
135137
fi
136138

0 commit comments

Comments
 (0)