Skip to content

Commit 2d0aa57

Browse files
committed
Auto merge of #112645 - Kobzol:ci-mingw-merge, r=pietroalbini
CI: merge `mingw` test CI jobs Same as #112633, but for `mingw`. From the logs it looks like the runner spends 40 minutes compiling `rustc`, and then `10`/`20` minutes running tests. It seems wasteful to split that into two jobs. CI run: https://github.com/rust-lang/rust/actions/runs/5275702134/jobs/9541479343?pr=112645 r? `@jyn514`
2 parents 9397862 + f3a4cf1 commit 2d0aa57

File tree

3 files changed

+14
-52
lines changed

3 files changed

+14
-52
lines changed

.github/workflows/ci.yml

+4-18
Original file line numberDiff line numberDiff line change
@@ -417,30 +417,16 @@ jobs:
417417
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --save-toolstates=/tmp/toolstate/toolstates.json"
418418
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json
419419
os: windows-2019-8core-32gb
420-
- name: i686-mingw-1
420+
- name: i686-mingw
421421
env:
422422
RUST_CONFIGURE_ARGS: "--build=i686-pc-windows-gnu"
423-
SCRIPT: make ci-mingw-subset-1
423+
SCRIPT: make ci-mingw
424424
NO_DOWNLOAD_CI_LLVM: 1
425425
CUSTOM_MINGW: 1
426426
os: windows-2019-8core-32gb
427-
- name: i686-mingw-2
427+
- name: x86_64-mingw
428428
env:
429-
RUST_CONFIGURE_ARGS: "--build=i686-pc-windows-gnu"
430-
SCRIPT: make ci-mingw-subset-2
431-
NO_DOWNLOAD_CI_LLVM: 1
432-
CUSTOM_MINGW: 1
433-
os: windows-2019-8core-32gb
434-
- name: x86_64-mingw-1
435-
env:
436-
SCRIPT: make ci-mingw-subset-1
437-
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-gnu --enable-profiler"
438-
NO_DOWNLOAD_CI_LLVM: 1
439-
CUSTOM_MINGW: 1
440-
os: windows-2019-8core-32gb
441-
- name: x86_64-mingw-2
442-
env:
443-
SCRIPT: make ci-mingw-subset-2
429+
SCRIPT: make ci-mingw
444430
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-gnu --enable-profiler"
445431
NO_DOWNLOAD_CI_LLVM: 1
446432
CUSTOM_MINGW: 1

src/bootstrap/mk/Makefile.in

+6-8
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,11 @@ ci-msvc:
6565

6666
## MingW native builders
6767

68-
TESTS_IN_MINGW_2 := \
69-
tests/ui
70-
71-
ci-mingw-subset-1:
72-
$(Q)$(CFG_SRC_DIR)/x test --stage 2 $(TESTS_IN_MINGW_2:%=--exclude %)
73-
ci-mingw-subset-2:
74-
$(Q)$(BOOTSTRAP) test --stage 2 $(TESTS_IN_MINGW_2)
75-
68+
# test both x and bootstrap entrypoints
69+
ci-mingw-x:
70+
$(Q)$(CFG_SRC_DIR)/x test --stage 2 tidy
71+
ci-mingw-bootstrap:
72+
$(Q)$(BOOTSTRAP) test --stage 2 --exclude tidy
73+
ci-mingw: ci-mingw-x ci-mingw-bootstrap
7674

7775
.PHONY: dist

src/ci/github-actions/ci.yml

+4-26
Original file line numberDiff line numberDiff line change
@@ -639,41 +639,19 @@ jobs:
639639
# came from the mingw-w64 SourceForge download site. Unfortunately
640640
# SourceForge is notoriously flaky, so we mirror it on our own infrastructure.
641641

642-
- name: i686-mingw-1
642+
- name: i686-mingw
643643
env:
644644
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu
645-
SCRIPT: make ci-mingw-subset-1
645+
SCRIPT: make ci-mingw
646646
# We are intentionally allowing an old toolchain on this builder (and that's
647647
# incompatible with LLVM downloads today).
648648
NO_DOWNLOAD_CI_LLVM: 1
649649
CUSTOM_MINGW: 1
650650
<<: *job-windows-8c
651651

652-
- name: i686-mingw-2
652+
- name: x86_64-mingw
653653
env:
654-
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu
655-
SCRIPT: make ci-mingw-subset-2
656-
# We are intentionally allowing an old toolchain on this builder (and that's
657-
# incompatible with LLVM downloads today).
658-
NO_DOWNLOAD_CI_LLVM: 1
659-
CUSTOM_MINGW: 1
660-
<<: *job-windows-8c
661-
662-
- name: x86_64-mingw-1
663-
env:
664-
SCRIPT: make ci-mingw-subset-1
665-
RUST_CONFIGURE_ARGS: >-
666-
--build=x86_64-pc-windows-gnu
667-
--enable-profiler
668-
# We are intentionally allowing an old toolchain on this builder (and that's
669-
# incompatible with LLVM downloads today).
670-
NO_DOWNLOAD_CI_LLVM: 1
671-
CUSTOM_MINGW: 1
672-
<<: *job-windows-8c
673-
674-
- name: x86_64-mingw-2
675-
env:
676-
SCRIPT: make ci-mingw-subset-2
654+
SCRIPT: make ci-mingw
677655
RUST_CONFIGURE_ARGS: >-
678656
--build=x86_64-pc-windows-gnu
679657
--enable-profiler

0 commit comments

Comments
 (0)