Add tidy check to ensure that the tests present in src/test/ui/rustdoc are present in src/test/rustdoc-ui

Author: GuillaumeGomez

src/tools/tidy/src/lib.rs

@@ -46,6 +46,7 @@ pub mod errors;
 pub mod extdeps;
 pub mod features;
 pub mod pal;
+pub mod rustdoc_ui_test_parity;
 pub mod style;
 pub mod target_specific_tests;
 pub mod ui_tests;

src/tools/tidy/src/main.rs

@@ -64,6 +64,7 @@ fn main() {
         // Checks over tests.
         check!(debug_artifacts, &src_path);
         check!(ui_tests, &src_path);
+        check!(rustdoc_ui_test_parity, &src_path);
 
         // Checks that only make sense for the compiler.
         check!(errors, &compiler_path);

src/tools/tidy/src/rustdoc_ui_test_parity.rs

@@ -0,0 +1,37 @@
+//! Tidy check to ensure that `src/test/ui/rustdoc` tests are all present in `src/test/rustdoc-ui`.
+
+use std::collections::HashSet;
+use std::path::Path;
+
+pub fn check(path: &Path, bad: &mut bool) {
+    let rustdoc_ui_folder = "src/test/rustdoc-ui";
+    let ui_rustdoc_folder = "src/test/ui/rustdoc";
+    let mut rustdoc_ui_tests = HashSet::new();
+    super::walk_no_read(&path.join("test/rustdoc-ui"), &mut |_| false, &mut |entry| {
+        let file_path = entry.path();
+        if let Some(ext) = file_path.extension() {
+            if ext == "rs" {
+                let testname = file_path.file_name().unwrap().to_str().unwrap().to_owned();
+                rustdoc_ui_tests.insert(testname);
+            }
+        }
+    });
+    super::walk_no_read(&path.join("test/ui/rustdoc"), &mut |_| false, &mut |entry| {
+        let file_path = entry.path();
+        if let Some(ext) = file_path.extension() {
+            if ext == "rs" {
+                let testname = file_path.file_name().unwrap().to_str().unwrap().to_owned();
+                if !rustdoc_ui_tests.contains(&testname) {
+                    tidy_error!(
+                        bad,
+                        "{}",
+                        &format!(
+                            "`{}/{}` is missing from `{}`",
+                            ui_rustdoc_folder, testname, rustdoc_ui_folder,
+                        ),
+                    );
+                }
+            }
+        }
+    });
+}