Add support for dylibs with Address Sanitizer

Author: Firstyear

src/librustc_metadata/creader.rs

@@ -858,11 +858,14 @@ impl<'a> CrateLoader<'a> {
                 match *ct {
                     // Link the runtime
                     config::CrateTypeExecutable => true,
+                    config::CrateTypeDylib => true,
+                    config::CrateTypeCdylib => true,
+                    config::CrateTypeStaticlib => true,
                     // This crate will be compiled with the required
                     // instrumentation pass
                     config::CrateTypeRlib => false,
                     _ => {
-                        self.sess.err(&format!("Only executables and rlibs can be \
+                        self.sess.err(&format!("Only executables, dylibs and rlibs can be \
                                                 compiled with `-Z sanitizer`"));
                         false
                     }

src/test/run-make/sanitizer-dylib-link/Makefile

@@ -0,0 +1,19 @@
+-include ../tools.mk
+
+# This test builds a shared object, then an executable that links it as a native
+# rust library (constrast to an rlib). The shared library and executable both
+# are compiled with address sanitizer, and we assert that a fault in the dylib
+# is correctly detected.
+
+# Note: currently we have to add -lasan to link, because it's not automatically
+# added in the -Z sanitizer=address process.
+
+ifeq ($(TARGET),x86_64-unknown-linux-gnu)
+all:
+	$(RUSTC) -g -Z sanitizer=address --crate-type dylib --target $(TARGET) -lasan library.rs
+	$(RUSTC) -g -Z sanitizer=address --crate-type bin --target $(TARGET) -lasan -llibrary program.rs
+	echo $(RUSTC)
+	LD_LIBRARY_PATH=$(TMPDIR) $(TMPDIR)/program 2>&1 | grep -q stack-buffer-overflow
+else
+all:
+endif

src/test/run-make/sanitizer-dylib-link/library.rs

@@ -0,0 +1,15 @@
+// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+#[no_mangle]
+pub extern fn overflow() {
+    let xs = [0, 1, 2, 3];
+    let y = unsafe { *xs.as_ptr().offset(4) };
+}

src/test/run-make/sanitizer-dylib-link/program.rs

@@ -0,0 +1,17 @@
+// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+extern {
+    fn overflow();
+}
+
+fn main() {
+    unsafe { overflow() }
+}

src/test/run-make/sanitizer-dylib/Makefile

@@ -0,0 +1,8 @@
+-include ../tools.mk
+
+ifeq ($(TARGET),x86_64-unknown-linux-gnu)
+all:
+	$(RUSTC) -Z sanitizer=leak --crate-type proc-macro --target $(TARGET) hello.rs 2>&1 | grep -q 'Only executables, dylibs and rlibs can be compiled with `-Z sanitizer`'
+else
+all:
+endif