Skip to content

Commit 2646db9

Browse files
committed
Remove //@ ignore-windows-gnu from tests that need the profiler
The profiler runtime is no longer built in mingw test jobs, so these tests should naturally be skipped by `//@ needs-profiler-support`.
1 parent 3f3b8bb commit 2646db9

File tree

8 files changed

+0
-28
lines changed

8 files changed

+0
-28
lines changed

src/tools/compiletest/src/header.rs

-3
Original file line numberDiff line numberDiff line change
@@ -1023,9 +1023,6 @@ fn iter_header(
10231023
if mode == Mode::CoverageRun {
10241024
let extra_directives: &[&str] = &[
10251025
"needs-profiler-support",
1026-
// FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
1027-
// properly. Since we only have GCC on the CI ignore the test for now.
1028-
"ignore-windows-gnu",
10291026
// FIXME(pietroalbini): this test currently does not work on cross-compiled
10301027
// targets because remote-test is not capable of sending back the *.profraw
10311028
// files generated by the LLVM instrumentation.

tests/run-make/optimization-remarks-dir-pgo/Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
PROFILE_DIR=$(TMPDIR)/profiles

tests/run-make/pgo-branch-weights/rmake.rs

-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
//@ needs-profiler-support
1111
//@ ignore-cross-compile
1212

13-
// FIXME(Oneirical): This test has problems generating profdata on mingw.
14-
// For more information, see https://github.com/rust-lang/rust/pull/122613
15-
//@ ignore-windows-gnu
16-
1713
use run_make_support::{fs_wrapper, llvm_filecheck, llvm_profdata, run_with_args, rustc};
1814
use std::path::Path;
1915

tests/run-make/pgo-gen-lto/Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
COMPILE_FLAGS=-Copt-level=3 -Clto=fat -Cprofile-generate="$(TMPDIR)"

tests/run-make/pgo-gen/Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
COMPILE_FLAGS=-g -Cprofile-generate="$(TMPDIR)"

tests/run-make/pgo-indirect-call-promotion/Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
all:

tests/run-make/pgo-use/Makefile

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32
# ignore-cross-compile
43

5-
# FIXME(mati865): MinGW GCC miscompiles compiler-rt profiling library but with Clang it works
6-
# properly. Since we only have GCC on the CI ignore the test for now.
7-
84
include ../tools.mk
95

106
# This test makes sure that PGO profiling data leads to cold functions being

tests/run-make/track-pgo-dep-info/Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
# needs-profiler-support
2-
# ignore-windows-gnu
32

43
include ../tools.mk
54

0 commit comments

Comments
 (0)