Fix library build and add more tests and a TODO list

Author: saethlin

library/core/src/ptr/mod.rs

@@ -1432,7 +1432,8 @@ pub const unsafe fn read<T>(src: *const T) -> T {
             (
                 addr: *const () = src as *const (),
                 align: usize = align_of::<T>(),
-            ) => ub_checks::is_aligned_and_not_null(addr, align)
+                is_zst: bool = T::IS_ZST,
+            ) => ub_checks::is_aligned_and_not_null(addr, align, is_zst)
         );
         crate::intrinsics::read_via_copy(src)
     }
@@ -1637,7 +1638,8 @@ pub const unsafe fn write<T>(dst: *mut T, src: T) {
             (
                 addr: *mut () = dst as *mut (),
                 align: usize = align_of::<T>(),
-            ) => ub_checks::is_aligned_and_not_null(addr, align)
+                is_zst: bool = T::IS_ZST,
+            ) => ub_checks::is_aligned_and_not_null(addr, align, is_zst)
         );
         intrinsics::write_via_move(dst, src)
     }

tests/ui/precondition-checks/TODO

@@ -0,0 +1,32 @@
+ptr::swap_nonoverlapping
+ptr::replace
+ptr::read
+ptr::write
+ptr::read_volatile
+ptr::write_volatile
+
+// for range::Range and for ops::Range?
+str::get_unchecked
+str::get_unchecked_mut
+
+IndexRange::new_unchecked
+
+char::from_u32_unchecked
+ascii::Char::digit_unchecked
+
+ptr::copy
+ptr::write_bytes
+
+slice::from_raw_parts
+slice::from_raw_parts_mut
+
+unchecked_add
+unchecked_sub
+unchecked_mul
+unchecked_shr
+unchecked_shl
+
+NonZero::from_mut_unchecked
+
+unreachable_unchecked
+assert_unchecked

tests/ui/precondition-checks/alignment.rs

@@ -0,0 +1,12 @@
+//@ run-fail
+//@ compile-flags: -Copt-level=3 -Cdebug-assertions=no -Zub-checks=yes
+//@ error-pattern: unsafe precondition(s) violated: Alignment::new_unchecked
+//@ ignore-debug
+
+#![feature(ptr_alignment_type)]
+
+fn main() {
+    unsafe {
+        std::ptr::Alignment::new_unchecked(0);
+    }
+}

tests/ui/precondition-checks/layout-overflow-isize.rs

@@ -0,0 +1,10 @@
+//@ run-fail
+//@ compile-flags: -Copt-level=3 -Cdebug-assertions=no -Zub-checks=yes
+//@ error-pattern: unsafe precondition(s) violated: Layout::from_size_align_unchecked
+//@ ignore-debug
+
+fn main() {
+    unsafe {
+        std::alloc::Layout::from_size_align_unchecked(isize::MAX as usize, 2);
+    }
+}

tests/ui/precondition-checks/nonnull-null.rs

@@ -0,0 +1,10 @@
+//@ run-fail
+//@ compile-flags: -Copt-level=3 -Cdebug-assertions=no -Zub-checks=yes
+//@ error-pattern: unsafe precondition(s) violated: NonNull::new_unchecked
+//@ ignore-debug
+
+fn main() {
+    unsafe {
+        std::ptr::NonNull::new_unchecked(std::ptr::null_mut::<u8>());
+    }
+}