---

yaml
---
r: 147935
b: refs/heads/try2
c: ada9150
h: refs/heads/master
i:
  147933: 84ef209
  147931: 689700b
  147927: 2e67187
  147919: c1f3ec0
  147903: 4d59844
v: v3

Author: pcwalton

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
 refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: 39f0270544af19bf51b0088c93fe5cf58a8eccbe
+refs/heads/try2: ada9150abf26912478aa6f613602f8ac7ba135e5
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/libsyntax/ext/expand.rs

@@ -1319,7 +1319,7 @@ mod test {
     }
 
     fn fake_print_crate(crate: &ast::Crate) {
-        let out = @mut std::io::stderr() as @mut std::io::Writer;
+        let mut out = ~std::io::stderr() as ~std::io::Writer;
         let s = pprust::rust_printer(out, get_ident_interner());
         pprust::print_crate_(s, crate);
     }

branches/try2/src/libsyntax/print/pprust.rs

@@ -122,7 +122,7 @@ pub fn print_crate(cm: @CodeMap,
                    span_diagnostic: @diagnostic::SpanHandler,
                    crate: &ast::Crate,
                    filename: @str,
-                   input: @mut io::Reader,
+                   input: &mut io::Reader,
                    out: ~io::Writer,
                    ann: @pp_ann,
                    is_expanded: bool) {
@@ -211,13 +211,8 @@ pub fn fun_to_str(decl: &ast::fn_decl, purity: ast::purity, name: ast::Ident,
     end(&mut s); // Close the head box
     end(&mut s); // Close the outer box
     eof(&mut s.s);
-
-    // XXX(pcwalton): Need checked downcasts.
     unsafe {
-        let (_, wr): (uint, ~MemWriter) = cast::transmute(s.s.out);
-        let result = str::from_utf8_owned(wr.inner_ref().to_owned());
-        cast::forget(wr);
-        result
+        get_mem_writer(&mut s.s.out)
     }
 }
 
@@ -230,13 +225,8 @@ pub fn block_to_str(blk: &ast::Block, intr: @ident_interner) -> ~str {
     ibox(&mut s, 0u);
     print_block(&mut s, blk);
     eof(&mut s.s);
-
-    // XXX(pcwalton): Need checked downcasts.
     unsafe {
-        let (_, wr): (uint, ~MemWriter) = cast::transmute(s.s.out);
-        let result = str::from_utf8_owned(wr.inner_ref().to_owned());
-        cast::forget(wr);
-        result
+        get_mem_writer(&mut s.s.out)
     }
 }
 
@@ -2318,17 +2308,23 @@ pub fn print_string(s: &mut ps, st: &str, style: ast::StrStyle) {
     word(&mut s.s, st);
 }
 
+// XXX(pcwalton): A nasty function to extract the string from an `io::Writer`
+// that we "know" to be a `MemWriter` that works around the lack of checked
+// downcasts.
+unsafe fn get_mem_writer(writer: &mut ~io::Writer) -> ~str {
+    let (_, wr): (uint, ~MemWriter) = cast::transmute_copy(writer);
+    let result = str::from_utf8_owned(wr.inner_ref().to_owned());
+    cast::forget(wr);
+    result
+}
+
 pub fn to_str<T>(t: &T, f: |&mut ps, &T|, intr: @ident_interner) -> ~str {
     let wr = ~MemWriter::new();
     let mut s = rust_printer(wr as ~io::Writer, intr);
     f(&mut s, t);
     eof(&mut s.s);
-    // XXX(pcwalton): Need checked downcasts.
     unsafe {
-        let (_, wr): (uint, ~MemWriter) = cast::transmute(s.s.out);
-        let result = str::from_utf8_owned(wr.inner_ref().to_owned());
-        cast::forget(wr);
-        result
+        get_mem_writer(&mut s.s.out)
     }
 }