Skip to content

Commit 74dd50c

Browse files
authored
Fix lifetimes elision suggestion in where clauses (#13752)
Fix #13749 changelog: [`needless_lifetimes`]: do not suggest using `'_` in `where` clauses
2 parents 2ddfc92 + 2b0e7bb commit 74dd50c

File tree

3 files changed

+28
-6
lines changed

3 files changed

+28
-6
lines changed

clippy_lints/src/lifetimes.rs

-6
Original file line numberDiff line numberDiff line change
@@ -658,12 +658,6 @@ fn report_elidable_impl_lifetimes<'tcx>(
658658
lifetime,
659659
in_where_predicate: false,
660660
..
661-
}
662-
| Usage {
663-
lifetime,
664-
in_bounded_ty: false,
665-
in_generics_arg: false,
666-
..
667661
},
668662
] = usages.as_slice()
669663
{

tests/ui/needless_lifetimes.fixed

+14
Original file line numberDiff line numberDiff line change
@@ -562,4 +562,18 @@ mod rayon {
562562
}
563563
}
564564

565+
mod issue13749 {
566+
pub struct Generic<T>(T);
567+
// Non elidable lifetime
568+
#[expect(clippy::extra_unused_lifetimes)]
569+
impl<'a, T> Generic<T> where T: 'a {}
570+
}
571+
572+
mod issue13749bis {
573+
pub struct Generic<T>(T);
574+
// Non elidable lifetime
575+
#[expect(clippy::extra_unused_lifetimes)]
576+
impl<'a, T: 'a> Generic<T> {}
577+
}
578+
565579
fn main() {}

tests/ui/needless_lifetimes.rs

+14
Original file line numberDiff line numberDiff line change
@@ -562,4 +562,18 @@ mod rayon {
562562
}
563563
}
564564

565+
mod issue13749 {
566+
pub struct Generic<T>(T);
567+
// Non elidable lifetime
568+
#[expect(clippy::extra_unused_lifetimes)]
569+
impl<'a, T> Generic<T> where T: 'a {}
570+
}
571+
572+
mod issue13749bis {
573+
pub struct Generic<T>(T);
574+
// Non elidable lifetime
575+
#[expect(clippy::extra_unused_lifetimes)]
576+
impl<'a, T: 'a> Generic<T> {}
577+
}
578+
565579
fn main() {}

0 commit comments

Comments
 (0)