Skip to content

Rename TypeKind::Named to TypeKind::TypeParam #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fitzgen opened this issue Aug 14, 2017 · 4 comments
Closed

Rename TypeKind::Named to TypeKind::TypeParam #914

fitzgen opened this issue Aug 14, 2017 · 4 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Aug 14, 2017

And anywhere we refer to "named" types, we should start referring to "type parameters".

If you want to pick this up, just drop a comment :)

I suggest starting by reading CONTRIBUTING.md and running the tests locally, then diving right into this bug.

@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@anna-liao
Copy link
Contributor

I'm interested in working on this issue. I followed the contributing.md and it build ok, but a few tests failed when I ran cargo test.

failures:
header_auto_hpp
header_const_bool_hpp
header_constant_evaluate_h
header_issue_769_bad_instantiation_test_hpp
header_objc_template_h
header_partial_specialization_and_inheritance_hpp
header_type_alias_template_specialized_hpp

test result: FAILED. 339 passed; 7 failed; 0 ignored; 0 measured

It may be specifying the path for libclang. How do I find the path for libclang on Mac OS?

@highfive: assign me

@fitzgen
Copy link
Member Author

fitzgen commented Aug 15, 2017

Hi @anna-liao ! Can you try following the instructions here for getting libclang >= 3.9? https://rust-lang-nursery.github.io/rust-bindgen/requirements.html#clang

I think you can pretty much brew install llvm and then set the LIBCLANG_PATH=/usr/local/Cellar/... env var to the directory where the libclang.dylib resides.

@fitzgen
Copy link
Member Author

fitzgen commented Aug 23, 2017

Fixed in #915

@fitzgen fitzgen closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants