Skip to content

bindgen crashes in mangling code on windows #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
upsuper opened this issue Feb 9, 2017 · 3 comments
Closed

bindgen crashes in mangling code on windows #502

upsuper opened this issue Feb 9, 2017 · 3 comments

Comments

@upsuper
Copy link
Contributor

upsuper commented Feb 9, 2017

It is crashing now... I'll try to find out the reason and update in the issue after other parts of the build finishes.

@upsuper
Copy link
Contributor Author

upsuper commented Feb 10, 2017

Code triggers this:

// bindgen-flags: -- --target=x86_64-pc-win32

template<typename Method, bool Cancelable>
struct nsRunnableMethodTraits;

template<class C, typename R, bool Cancelable, typename... As>
struct nsRunnableMethodTraits<R(C::*)(As...), Cancelable>
{
  static const bool can_cancel = Cancelable;
};

It only happens when Windows target is specified, which is probably why other people doesn't meet it even that this is part of m-c code.

@upsuper
Copy link
Contributor Author

upsuper commented Feb 10, 2017

But in theory this shouldn't happen, because we should have already exclude templates from generating mangling name... which indicates that the code there is still imperfect.

@emilio
Copy link
Contributor

emilio commented Apr 22, 2017

This was fixed.

@emilio emilio closed this as completed Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants