Skip to content

Figure out a more idiomatic way to check if we should generate comments. #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emilio opened this issue Jan 26, 2017 · 2 comments
Open
Labels
good first issue To denote that new-to-project folks can do this, even if with some help help wanted I-cleanup

Comments

@emilio
Copy link
Contributor

emilio commented Jan 26, 2017

in #444 I pretty much wrapped everything in an if block, but @fitzgen suggested it may be a better idea to get the potential comment holders the context so they can check themselves.

@amanjeev
Copy link
Member

amanjeev commented Sep 19, 2022

Adding more context to this during triage:

Code review comment by @fitzgen : https://github.com/rust-lang/rust-bindgen/pull/444/files#r98064839

This is a whole lot of copy paste... What if we made Item::comment and Field::comment take the context and check themselves? The earlier we push this check, we could even potentially avoid keeping the comments around in memory.

@kulp @emilio can any of you please add a tag about "good first issue". That is missing in the list. Or let me know if any other tag is used in place of that.

@amanjeev amanjeev added the good first issue To denote that new-to-project folks can do this, even if with some help label Sep 27, 2022
@kulp
Copy link
Member

kulp commented Oct 22, 2022

@kulp @emilio can any of you please add a tag about "good first issue".

@amanjeev sorry to be unavailable for such long periods; but I think you / @pvdrz have all the rights you need now. Thanks for handling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue To denote that new-to-project folks can do this, even if with some help help wanted I-cleanup
Projects
None yet
Development

No branches or pull requests

5 participants