Skip to content

Make ItemId local to the BindgenContext. #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emilio opened this issue Nov 15, 2016 · 3 comments
Closed

Make ItemId local to the BindgenContext. #262

emilio opened this issue Nov 15, 2016 · 3 comments

Comments

@emilio
Copy link
Contributor

emilio commented Nov 15, 2016

See for example #204, where that caused an spurious name change.
@emilio emilio mentioned this issue Nov 15, 2016
Merged
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

@emilio emilio added the E-easy label Nov 15, 2016
@emilio emilio changed the title Make ItemId local to the context. Make ItemId local to the BindgenContext. Nov 15, 2016
@emilio emilio added E-less-easy and removed E-easy labels Nov 15, 2016
@emilio
Copy link
Contributor Author

emilio commented Nov 15, 2016

We should create a new field in BindgenContext, called last_item_id, and use and increment that instead of the global atomic.

@emilio
Copy link
Contributor Author

emilio commented Nov 15, 2016

This was blocking stuff, so I just did it in #263

@emilio emilio closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilio @highfive