You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #2166 was completed, there are no more instances of ::is_loaded() in the code for checking individual functions. At a minimum, I think this means we could stop using the clang-sys/runtime feature.
Does the lack of ::is_loaded() calls also mean that we could get rid of the rust-bindgen/runtime feature ?
This probably is not as worthwhile as I thought. Apart from cutting the load on CI in half, the amount of change to rust-bindgen source code seems pretty minimal, so it is not as if a lot of maintainability is to be gained.
Since #2166 was completed, there are no more instances of
::is_loaded()
in the code for checking individual functions. At a minimum, I think this means we could stop using theclang-sys/runtime
feature.Does the lack of
::is_loaded()
calls also mean that we could get rid of therust-bindgen/runtime
feature ?Originally posted by @kulp in #2166 (comment)
The text was updated successfully, but these errors were encountered: