Skip to content

Remove runtime feature if no longer needed #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kulp opened this issue Mar 15, 2022 · 1 comment
Closed

Remove runtime feature if no longer needed #2178

kulp opened this issue Mar 15, 2022 · 1 comment

Comments

@kulp
Copy link
Member

kulp commented Mar 15, 2022

Since #2166 was completed, there are no more instances of ::is_loaded() in the code for checking individual functions. At a minimum, I think this means we could stop using the clang-sys/runtime feature.

Does the lack of ::is_loaded() calls also mean that we could get rid of the rust-bindgen/runtime feature ?

Originally posted by @kulp in #2166 (comment)

@kulp
Copy link
Member Author

kulp commented Mar 16, 2022

This probably is not as worthwhile as I thought. Apart from cutting the load on CI in half, the amount of change to rust-bindgen source code seems pretty minimal, so it is not as if a lot of maintainability is to be gained.

I am closing this issue as not-very-important.

@kulp kulp closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant