Skip to content

Contributing testing guidelines install out-of-date rustfmt #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KarelPeeters opened this issue Jul 23, 2021 · 1 comment
Closed

Contributing testing guidelines install out-of-date rustfmt #2080

KarelPeeters opened this issue Jul 23, 2021 · 1 comment

Comments

@KarelPeeters
Copy link
Contributor

I'm trying to contribute to rust-bindgen for the first time, and I got hung up around here in CONTRIBUTING.md:

The generated and expected bindings are run through rustfmt before they are compared. Make sure >you have rustfmt up to date:

$ rustup update nightly
$ rustup run nightly cargo install -f rustfmt-nightly

This second command installs an older version of rustfmt that doesn't compile on nightly any more. It looks like this step can simply be skipped, since rustfmt is now included by default.

@emilio emilio closed this as completed in d79922d Jul 25, 2021
@emilio
Copy link
Contributor

emilio commented Jul 25, 2021

I tweaked to suggest rustup component add ... in case you have minimal toolchains, but yeah, thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants